mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "J. Bruce Fields" <bfields@fieldses.org>
To: Peter Staubach <staubach@redhat.com>
Cc: Trond Myklebust <trond.myklebust@fys.uio.no>,
	Neil Brown <neilb@suse.de>, NFS List <nfs@lists.sourceforge.net>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [NFS] [PATCH] NFS server does not update mtime on setattr request
Date: Wed, 7 Jun 2006 11:17:54 -0400	[thread overview]
Message-ID: <20060607151754.GB23954@fieldses.org> (raw)
In-Reply-To: <4486E662.5080900@redhat.com>

On Wed, Jun 07, 2006 at 10:44:50AM -0400, Peter Staubach wrote:
> I saw that wording too and assumed what I think that you assumed.  I
> assumed that that meant that if the new size is equal to the old size,
> then nothing should be changed.  However, that does not seem to be how
> those words are to be interpreted.  They are to be interpreted as "if
> the new length of the file can be successfully set, then the
> mtime/ctime should be changed".

What's the basis for that interpretation?  The language seems extremely
clear:

	"On successful completion, if the file size is changed, these
	functions will mark for update the st_ctime and st_mtime fields
	of the file, and if the file is a regular file, the S_ISUID and
	S_ISGID bits of the file mode may be cleared."

Why are you concerned about this?  Do you have an actual application
that breaks?

--b.

  reply	other threads:[~2006-06-07 15:18 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-06-06 18:05 Peter Staubach
2006-06-07  5:38 ` Trond Myklebust
2006-06-07 14:44   ` Peter Staubach
2006-06-07 15:17     ` J. Bruce Fields [this message]
2006-06-07 15:26       ` [NFS] " Peter Staubach
2006-06-07 15:39         ` Trond Myklebust
2006-06-07 15:44           ` Peter Staubach
2006-06-07 17:17             ` Trond Myklebust
2006-06-07 17:41               ` Peter Staubach
2006-06-07 15:42         ` J. Bruce Fields
2006-06-07 15:50           ` Peter Staubach
2006-06-07 16:03             ` J. Bruce Fields
2006-06-07 16:56               ` Peter Staubach
2006-06-09  0:40     ` Neil Brown
2006-06-09 13:10       ` Peter Staubach

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060607151754.GB23954@fieldses.org \
    --to=bfields@fieldses.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=neilb@suse.de \
    --cc=nfs@lists.sourceforge.net \
    --cc=staubach@redhat.com \
    --cc=trond.myklebust@fys.uio.no \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®