From: "Randy.Dunlap" <rdunlap@xenotime.net>
To: Andrew Morton <akpm@osdl.org>
Cc: jamagallon@ono.com, linux-kernel@vger.kernel.org, sam@ravnborg.org
Subject: [PATCH] ignore smp_locks section warnings from init/exit code
Date: Wed, 7 Jun 2006 16:23:26 -0700 [thread overview]
Message-ID: <20060607162326.3d2cc76b.rdunlap@xenotime.net> (raw)
In-Reply-To: <20060607154054.cf4f2512.akpm@osdl.org>
On Wed, 7 Jun 2006 15:40:54 -0700 Andrew Morton wrote:
> On Thu, 8 Jun 2006 00:31:53 +0200
> "J.A. Magallón" <jamagallon@ono.com> wrote:
>
> > WARNING: drivers/block/floppy.o - Section mismatch: reference to .init.text: from .smp_locks after '' (at offset 0x3c)
> > WARNING: drivers/block/floppy.o - Section mismatch: reference to .init.text: from .smp_locks after '' (at offset 0x40)
> > WARNING: drivers/block/floppy.o - Section mismatch: reference to .init.text: from .smp_locks after '' (at offset 0x44)
>
> Yes, that's a false positive - doing locking from within an __init section.
> We need to shut that up somehow.
I currently only see this in an __exit section.
Here is a patch that fixes it for me.
J.A., can you test it?
---
From: Randy Dunlap <rdunlap@xenotime.net>
Add ".smp_locks" section to whitelist as being safe from
init and exit sections.
Signed-off-by: Randy Dunlap <rdunlap@xenotime.net>
---
scripts/mod/modpost.c | 2 ++
1 files changed, 2 insertions(+)
--- linux-2617-rc6mm1.orig/scripts/mod/modpost.c
+++ linux-2617-rc6mm1/scripts/mod/modpost.c
@@ -852,6 +852,7 @@ static int init_section_ref_ok(const cha
".pci_fixup_final",
".pdr",
"__param",
+ ".smp_locks",
NULL
};
/* Start of section names */
@@ -923,6 +924,7 @@ static int exit_section_ref_ok(const cha
".exitcall.exit",
".eh_frame",
".stab",
+ ".smp_locks",
NULL
};
/* Start of section names */
next prev parent reply other threads:[~2006-06-07 23:20 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-06-07 17:47 2.6.17-rc6-mm1 Andrew Morton
2006-06-07 21:23 ` 2.6.17-rc6-mm1 J.A. Magallón
2006-06-07 22:07 ` 2.6.17-rc6-mm1 Ingo Molnar
2006-06-07 22:36 ` 2.6.17-rc6-mm1 J.A. Magallón
2006-06-07 23:54 ` 2.6.17-rc6-mm1 Stefan Richter
2006-06-08 0:31 ` 2.6.17-rc6-mm1 Chris Wright
2006-06-08 6:30 ` 2.6.17-rc6-mm1 Stefan Richter
2006-06-08 7:26 ` 2.6.17-rc6-mm1 Ingo Molnar
2006-06-07 21:54 ` 2.6.17-rc6-mm1 Rafael J. Wysocki
2006-06-07 22:11 ` 2.6.17-rc6-mm1 Ingo Molnar
2006-06-08 3:19 ` 2.6.17-rc6-mm1 Valdis.Kletnieks
2006-06-08 15:13 ` lockdep wierdness - was 2.6.17-rc6-mm1 Valdis.Kletnieks
2006-06-08 10:06 ` NTFS possible circular locking deadlock (Was: Re: 2.6.17-rc6-mm1) Duncan Sands
2006-06-12 14:35 ` Ingo Molnar
2006-06-08 12:54 ` 2.6.17-rc6-mm1 Rafael J. Wysocki
2006-06-07 22:31 ` 2.6.17-rc6-mm1 J.A. Magallón
2006-06-07 22:40 ` 2.6.17-rc6-mm1 Andrew Morton
2006-06-07 23:23 ` Randy.Dunlap [this message]
2006-06-08 0:04 ` [PATCH] ignore smp_locks section warnings from init/exit code Randy.Dunlap
2006-06-08 2:11 ` Jeff Dike
2006-06-08 2:32 ` Randy.Dunlap
2006-06-08 4:21 ` Jeff Dike
2006-06-08 4:29 ` Randy.Dunlap
2006-06-08 15:44 ` Randy.Dunlap
2006-06-08 18:35 ` Sam Ravnborg
2006-06-11 23:25 ` Jeff Dike
2006-06-12 0:17 ` Randy.Dunlap
2006-06-12 2:29 ` Jeff Dike
2006-06-12 2:52 ` Randy.Dunlap
2006-06-08 2:25 ` 2.6.17-rc6-mm1 Andi Kleen
2006-06-08 2:46 ` 2.6.17-rc6-mm1 Randy.Dunlap
2006-06-08 5:43 ` 2.6.17-rc6-mm1 Andi Kleen
2006-06-08 6:46 ` 2.6.17-rc6-mm1 Gerd Hoffmann
2006-06-07 23:14 ` 2.6.17-rc6-mm1 Martin Bligh
2006-06-07 23:55 ` 2.6.17-rc6-mm1 Andrew Morton
2006-06-08 1:09 ` 2.6.17-rc6-mm1 Grant Coady
2006-06-08 5:00 ` 2.6.17-rc6-mm1 Dave Jones
2006-06-20 17:42 ` 2.6.17-rc6-mm1 Arjan van de Ven
2006-06-20 20:24 ` 2.6.17-rc6-mm1 Andrew Morton
2006-06-20 20:38 ` 2.6.17-rc6-mm1 Arjan van de Ven
2006-06-21 6:23 ` 2.6.17-rc6-mm1 Dave Jones
2006-06-21 8:15 ` 2.6.17-rc6-mm1 Arjan van de Ven
2006-06-21 18:42 ` 2.6.17-rc6-mm1 Dave Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060607162326.3d2cc76b.rdunlap@xenotime.net \
--to=rdunlap@xenotime.net \
--cc=akpm@osdl.org \
--cc=jamagallon@ono.com \
--cc=linux-kernel@vger.kernel.org \
--cc=sam@ravnborg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome