mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Andreas Dilger <adilger@clusterfs.com>
To: "Adrian's Trivial Patches" <trivial@rustcorp.com.au>
Cc: linux-kernel@vger.kernel.org
Subject: [PATCH] use unlikely() for current_kernel_time() loop
Date: Wed, 7 Jun 2006 11:36:42 -0600	[thread overview]
Message-ID: <20060607173642.GA6378@schatzie.adilger.int> (raw)

Hello,
I just noticed this minor optimization.  current_kernel_time() is called
from current_fs_time() so it is used fairly often but it doesn't use
unlikely(read_seqretry(&xtime_lock, seq)) as other users of xtime_lock do.
Also removes extra whitespace on the empty line above.

Signed-off-by: Andreas Dilger <adilger@clusterfs.com>


--- ./kernel/time.c.orig	2006-05-08 15:40:43.000000000 -0600
+++ ./kernel/time.c	2006-06-07 11:24:49.000000000 -0600
@@ -424,9 +424,9 @@ inline struct timespec current_kernel_time
 
 	do {
 		seq = read_seqbegin(&xtime_lock);
-		
+
 		now = xtime;
-	} while (read_seqretry(&xtime_lock, seq));
+	} while (unlikely(read_seqretry(&xtime_lock, seq)));
 
 	return now; 
 }

Cheers, Andreas
--
Andreas Dilger
Principal Software Engineer
Cluster File Systems, Inc.


             reply	other threads:[~2006-06-07 17:36 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-06-07 17:36 Andreas Dilger [this message]
2006-06-08  2:28 ` Andi Kleen
2006-06-08  5:01   ` Andrew Morton
2006-06-08  5:39     ` Andi Kleen
2006-06-08  6:41       ` Brian F. G. Bidulock
2006-06-08  6:51         ` Andi Kleen
2006-06-08  7:00           ` Brian F. G. Bidulock
2006-06-08  7:07             ` Andi Kleen
2006-06-08  7:43               ` Brian F. G. Bidulock
2006-06-08  8:59               ` Brian F. G. Bidulock
2006-06-08  9:14                 ` Andi Kleen
2006-06-08  9:36                   ` Brian F. G. Bidulock
2006-06-08 10:20                     ` Andi Kleen
2006-06-08 10:50                       ` Brian F. G. Bidulock

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060607173642.GA6378@schatzie.adilger.int \
    --to=adilger@clusterfs.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=trivial@rustcorp.com.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®