From: "Randy.Dunlap" <rdunlap@xenotime.net>
To: Paul Fulghum <paulkf@microgate.com>
Cc: zippel@linux-m68k.org, akpm@osdl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] fix generic HDLC synclink mismatch build error
Date: Wed, 7 Jun 2006 19:38:33 -0700 [thread overview]
Message-ID: <20060607193833.e34c5827.rdunlap@xenotime.net> (raw)
In-Reply-To: <44876DF9.3070205@microgate.com>
On Wed, 07 Jun 2006 19:23:21 -0500 Paul Fulghum wrote:
> Roman Zippel wrote:
> > Hi,
> >
> > On Wed, 7 Jun 2006, Paul Fulghum wrote:
> >
> >
> >>-#ifdef CONFIG_HDLC_MODULE
> >>+#if defined(CONFIG_HDLC_MODULE) && defined(CONFIG_SYNCLINK_MODULE)
> >> #define CONFIG_HDLC 1
> >> #endif
> >
> >
> > Please don't define your own config symbols, just use Kconfig for this,
> > simply remove the prompts from your earlier patch and add the dependecies
> > as Randy suggested.
>
> Randy's patch defines config symbols, so I don't know what you are getting at.
Yes, but in the config language, not inside a driver source file.
---
~Randy
next prev parent reply other threads:[~2006-06-08 2:35 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-06-07 15:42 Paul Fulghum
2006-06-07 21:31 ` Randy.Dunlap
2006-06-07 21:43 ` Paul Fulghum
2006-06-07 21:48 ` Randy.Dunlap
2006-06-07 22:00 ` Paul Fulghum
2006-06-09 15:47 ` Paul Fulghum
2006-06-09 16:00 ` Roman Zippel
2006-06-09 16:16 ` Paul Fulghum
2006-06-09 16:37 ` Roman Zippel
2006-06-09 16:44 ` Paul Fulghum
2006-06-07 22:58 ` Roman Zippel
2006-06-08 0:23 ` Paul Fulghum
2006-06-08 2:38 ` Randy.Dunlap [this message]
2006-06-07 23:02 ` Jeff Garzik
2006-06-08 0:20 ` Paul Fulghum
2006-06-08 0:59 ` Paul Fulghum
2006-06-08 1:28 ` Andrew Morton
2006-06-08 1:52 ` Paul Fulghum
2006-06-08 13:20 ` Paul Fulghum
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060607193833.e34c5827.rdunlap@xenotime.net \
--to=rdunlap@xenotime.net \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=paulkf@microgate.com \
--cc=zippel@linux-m68k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®