From: Andrew Morton <akpm@osdl.org>
To: Andy Whitcroft <apw@shadowen.org>
Cc: ralf@linux-mips.org, linux-kernel@vger.kernel.org,
creese@caviumnetworks.com, apw@shadowen.org
Subject: Re: [PATCH] mem_map is part of the FLATMEM model
Date: Fri, 9 Jun 2006 17:23:06 -0700 [thread overview]
Message-ID: <20060609172306.0ce6bf86.akpm@osdl.org> (raw)
In-Reply-To: <20060609134850.GA20794@shadowen.org>
Andy Whitcroft <apw@shadowen.org> wrote:
>
> mem_map is part of the FLATMEM model
>
> It seems that the definition and declaration of mem_map are
> inconsistent meaning we get usless undirected link failures about
> mem_map when its being used when it shouldn't be.
>
> Reviewing mem_map, its actually only valid and initialised when
> CONFIG_FLATMEM is defined. Indeed in all essence it is part
> of that memory model used out of FLATMEM's __pfn_to_page etc.
> mem_map (and max_mapnr) should only be defined and declared when
> the FLATMEM memory model is selected.
sparc64 allmodconfig:
arch/sparc64/mm/init.c: In function `paging_init':
arch/sparc64/mm/init.c:1339: error: `max_mapnr' undeclared (first use in this function)
arch/sparc64/mm/init.c:1339: error: (Each undeclared identifier is reported only once
prev parent reply other threads:[~2006-06-10 0:20 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-05-31 16:23 mem_map definition / declaration Ralf Baechle
2006-05-31 17:00 ` Andy Whitcroft
2006-06-09 13:48 ` [PATCH] mem_map is part of the FLATMEM model Andy Whitcroft
2006-06-10 0:23 ` Andrew Morton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060609172306.0ce6bf86.akpm@osdl.org \
--to=akpm@osdl.org \
--cc=apw@shadowen.org \
--cc=creese@caviumnetworks.com \
--cc=linux-kernel@vger.kernel.org \
--cc=ralf@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome