mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Ingo Oeser <ioe-lkml@rameria.de>
To: "Leubner, Achim" <Achim_Leubner@adaptec.com>
Cc: "Christoph Hellwig" <hch@lst.de>, linux-kernel@vger.kernel.org
Subject: Re: HEADS UP for gdth driver users
Date: Sat, 10 Jun 2006 12:03:59 +0200	[thread overview]
Message-ID: <200606101204.00742.ioe-lkml@rameria.de> (raw)
In-Reply-To: <EF6AF37986D67948AD48624A3E5D93AFAA967C@mtce2k01.adaptec.com>

Hi Achim,

Thanks for working on this!

On Friday, 9. June 2006 13:03, Leubner, Achim wrote:
> Attached you find a patch to remove the scsi_request interface from the
> gdth driver. The patch contains your first patch, the changes for
> removing the scsi_request interface and some changes to preserve the
> 2.4.x compatibility.
> We tested it and it should work fine. It would be great if it could be
> integrated in the 2.6.18 cycle.

Your driver also uses lots of kernel version dependent
code in the main driver file.

Please implement new kernel API functions using old kernel API
functions and put these into your existing gdth_kcompat.h file.

Rationale: Linux drivers are required to be forward compatible instead of
	backward compatible. More details per private email, if your needed.

Other issues with your patch were already raised by Andrew and Christoph.


Regards

Ingo Oeser

  parent reply	other threads:[~2006-06-10 10:07 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-06-09 11:03 Leubner, Achim
2006-06-09 18:33 ` Andrew Morton
2006-06-09 18:34 ` Andrew Morton
2006-06-10 10:03 ` Ingo Oeser [this message]
  -- strict thread matches above, loose matches on Subject: below --
2006-06-16  9:21 Leubner, Achim
2006-04-25 10:54 Leubner, Achim
2006-04-24 12:21 Leubner, Achim
2006-04-25 10:33 ` Christoph Hellwig
2006-04-18 14:41 Leubner, Achim
2006-03-10 11:04 Leubner, Achim
2006-03-08 13:19 Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200606101204.00742.ioe-lkml@rameria.de \
    --to=ioe-lkml@rameria.de \
    --cc=Achim_Leubner@adaptec.com \
    --cc=hch@lst.de \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®