From: "Randy.Dunlap" <rdunlap@xenotime.net>
To: Diego Calleja <diegocg@gmail.com>
Cc: linux-kernel@vger.kernel.org, akpm@osdl.org,
netdev@vger.kernel.org, linux-xfs@oss.sgi.com, ecki@lina.inka.de,
lkml@rtr.ca
Subject: Re: Updated sysctl documentation take #2
Date: Sat, 10 Jun 2006 20:41:00 -0700 [thread overview]
Message-ID: <20060610204100.901a0de1.rdunlap@xenotime.net> (raw)
In-Reply-To: <20060608001806.028ab05a.diegocg@gmail.com>
On Thu, 8 Jun 2006 00:18:06 +0200 Diego Calleja wrote:
> El Wed, 7 Jun 2006 13:06:53 -0700,
> "Randy.Dunlap" <rdunlap@xenotime.net> escribió:
>
> > OK, that's all for the README file. I'll look at the rest of it
> > sometime this week. I don't think that it's quite ready to be merged.
>
> Thank's for your review, altought I didn't though someone was to review
> so deeply a documentation patch ;) I've gone through all the files and
> fixed the 72-col limit and everything I could. I've updated the patch
> http://terra.es/personal/diegocg/sysctl-docs
Here are some more comments for you.
1. There are quite a few lines (17) ending with ^M (carriage return)
that should be removed.
2. Lines like this one should end with a period (full stop):
+This file is SPARC-only
3. I would put this comment near the top of each file, not at
the end:
+PLEASE KEEP THIS FILE ORDERED ALPHABETICALLY.
Other than that, it's looking good to me.
Thanks,
---
~Randy
next prev parent reply other threads:[~2006-06-11 3:38 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-06-07 18:53 Diego Calleja
2006-06-07 19:46 ` Stephen Hemminger
2006-06-07 20:55 ` Diego Calleja
2006-06-07 21:24 ` [PATCH] Updated Documentation/networking/ip-sysctl.txt Robert Fitzsimons
2006-06-07 20:06 ` Updated sysctl documentation take #2 Randy.Dunlap
2006-06-07 22:18 ` Diego Calleja
2006-06-11 3:41 ` Randy.Dunlap [this message]
2006-06-07 23:56 ` Johannes Stezenbach
2006-06-07 22:52 ` David Lang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060610204100.901a0de1.rdunlap@xenotime.net \
--to=rdunlap@xenotime.net \
--cc=akpm@osdl.org \
--cc=diegocg@gmail.com \
--cc=ecki@lina.inka.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-xfs@oss.sgi.com \
--cc=lkml@rtr.ca \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®