Re: [PATCH] jffs2: fix section mismatches

[Sam Ravnborg <sam@ravnborg.org>]

On Sat, Jun 10, 2006 at 11:00:17PM +0100, David Woodhouse wrote:
> On Sat, 2006-06-10 at 13:28 -0700, Randy.Dunlap wrote:
> > Priority: not critical; makes init code discardable.
> > 
> > Fix section mismatch warnings:
> > WARNING: fs/jffs2/jffs2.o - Section mismatch: reference
> > to .init.text:jffs2_zlib_init from .text between
> > 'jffs2_compressors_init' (at offset 0x546) and
> > 'jffs2_compressors_exit' 
> 
> Some of this is already in -mm, isn't it?
> 
> I'm wary of this kind of change from drive-by patchers now -- I had to
> commit two fixes recently to remove __exit from functions which are
> actually called in the error case from the init function.
The check in modpost should have caught these and
flagged them?!?

> For those exit-and-error functions, I think we actually want an
> __initexit marker. In the built-in case, it can actually be discarded
> with the init code. In the modular case, it needs to be kept.
People have troubles enough getting it right today.
Just see the warnings that comes with an allmodconfig build.
So introducing more complexity for a corner case is not a good way
forward.

	Sam