Re: [RFC PATCH] kbuild support for %.symtypes files

[Andreas Gruenbacher <agruen@suse.de>]

On Saturday, 10 June 2006 22:33, Sam Ravnborg wrote:
> On Tue, May 09, 2006 at 08:37:30PM +0200, Andreas Gruenbacher wrote:
> > Hello,
> >
> > here is a patch that adds a new -T option to genksyms for generating
> > dumps of the type definition that makes up the symbol version hashes.
> > This allows to trace modversion changes back to what caused them. The
> > dump format is the name of the type defined, followed by its definition
> > (which is almost C):
> >
> >   s#list_head struct list_head { s#list_head * next , * prev ; }
>
> Reading something just a little more complex than the above was very
> difficult. So I went on and updated your patch to spit out something
> almost 'C' alike with proper indention and a few newlines too.
>
> The list_head struct looks like this now:
>
> struct#list_head  struct list_head {
> 	struct# list_head * next , * prev;
> };
>
> The real win is for structs with 20+ members, they are now divided up in
> several lines.

Please let's not beautify the output: this would make diffing and grepping 
harder. It's easy to pipe the simple, line oriented format through a 
formatting filter if necessary.

The output could be made more readable by converting the "x#" prefix to C 
keywords (struct, union, etc.). I didn't do this because that would introduce 
parse problems, and constructing dependency graphs from the dump files would 
become tricky.

Andreas

-- 
Andreas Gruenbacher <agruen@suse.de>
Novell / SUSE Labs