mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Luiz Fernando N. Capitulino" <lcapitulino@mandriva.com.br>
To: rmk+serial@arm.linux.org.uk
Cc: gregkh@suse.de, zaitcev@redhat.com, alan@lxorguk.ukuu.org.uk,
	linux-kernel@vger.kernel.org,
	linux-usb-devel@lists.sourceforge.net
Subject: Serial-Core: USB-Serial port current issues.
Date: Tue, 13 Jun 2006 19:28:29 -0300	[thread overview]
Message-ID: <20060613192829.3f4b7c34@home.brethil> (raw)


 Hi Russell,

 I'm working on the port of the USB-Serial layer to the Serial Core [1],
and turns out that most of the USB-Serial drivers does need to sleep in
set_termios(), break_ctl(), get_mctrl() and set_mctrl() calls (which are
not allowed to sleep according to the documentation).

 I took a look in the Serial Core code and didn't see why set_termios()
and break_ctl() (plus tx_empty()) are not allowed to sleep: they doesn't
seem to run in atomic context. So, are they allowed to sleep? Isn't the
documentation out of date? I've even submitted a patch to fix it [2].

 For get_mctrl() and set_mctrl() it seems possible to switch from a spinlock
to a mutex, as they are not called from an interrupt context. Is this
really possible? Would you agree with this change?

 Please, note that your opnion is very important. Both issues makes
the port not possible.

 Thanks.

[1] http://distro2.conectiva.com.br/~lcapitulino/patches/usbserial/2.6.17-rc5/serialcore-port-V0/
[2] http://marc.theaimsgroup.com/?l=linux-kernel&m=114979748706523&w=2

-- 
Luiz Fernando N. Capitulino

             reply	other threads:[~2006-06-13 22:25 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-06-13 22:28 Luiz Fernando N. Capitulino [this message]
2006-06-14 15:28 ` Russell King
2006-06-14 20:38   ` Luiz Fernando N. Capitulino
2006-06-15  0:53     ` Pete Zaitcev
2006-06-15 13:29       ` Luiz Fernando N. Capitulino
2006-06-15 16:07         ` Greg KH
2006-06-15 16:21           ` Luiz Fernando N. Capitulino
2006-06-20 19:11   ` Luiz Fernando N. Capitulino
2006-06-21  2:32     ` Pete Zaitcev
2006-06-21 16:35       ` Luiz Fernando N. Capitulino
2006-06-21 16:43         ` Russell King
2006-06-21 21:15           ` Luiz Fernando N. Capitulino
2006-06-22  8:29             ` Russell King
2006-06-23 17:28               ` Luiz Fernando N. Capitulino
2006-06-26 22:26                 ` Greg KH
2006-06-27  0:49                   ` Paul Fulghum
2006-07-04 19:42                     ` Luiz Fernando N. Capitulino
2006-07-04 19:50                       ` Pete Zaitcev
2006-07-04 20:36                         ` Luiz Fernando N. Capitulino
2006-07-05 13:40                       ` [linux-usb-devel] " Paul Fulghum

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060613192829.3f4b7c34@home.brethil \
    --to=lcapitulino@mandriva.com.br \
    --cc=alan@lxorguk.ukuu.org.uk \
    --cc=gregkh@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb-devel@lists.sourceforge.net \
    --cc=rmk+serial@arm.linux.org.uk \
    --cc=zaitcev@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®