From: David Miller <davem@davemloft.net>
To: heiko.carstens@de.ibm.com
Cc: jgarzik@pobox.com, akpm@osdl.org, linux-kernel@vger.kernel.org,
netdev@vger.kernel.org, mingo@elte.hu, fpavlic@de.ibm.com
Subject: Re: [patch] ipv4: fix lock usage in udp_ioctl
Date: Wed, 14 Jun 2006 15:16:17 -0700 (PDT) [thread overview]
Message-ID: <20060614.151617.122788798.davem@davemloft.net> (raw)
In-Reply-To: <20060614194305.GB10391@osiris.ibm.com>
From: Heiko Carstens <heiko.carstens@de.ibm.com>
Date: Wed, 14 Jun 2006 21:43:05 +0200
> From: Heiko Carstens <heiko.carstens@de.ibm.com>
>
> Fix lock usage in udp_ioctl().
>
> Signed-off-by: Heiko Carstens <heiko.carstens@de.ibm.com>
More likely the qeth driver shouldn't call into the socket code in
hardware interrupt context. From your logs that's what it seems is
happening.
The socket receive queue should only be touched in software
interrupt context, never in hardware interrupt context. That's
why the locking does BH disabling at best.
next prev parent reply other threads:[~2006-06-14 22:16 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-06-14 19:43 Heiko Carstens
2006-06-14 22:16 ` David Miller [this message]
2006-06-14 23:12 ` Herbert Xu
2006-06-15 5:28 ` Ingo Molnar
2006-06-15 6:55 ` Heiko Carstens
2006-06-15 10:52 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060614.151617.122788798.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=akpm@osdl.org \
--cc=fpavlic@de.ibm.com \
--cc=heiko.carstens@de.ibm.com \
--cc=jgarzik@pobox.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®