From: "Luiz Fernando N. Capitulino" <lcapitulino@mandriva.com.br>
To: Frank Gevaerts <frank.gevaerts@fks.be>
Cc: Mark Lord <lkml@rtr.ca>, Greg KH <gregkh@suse.de>,
Linux Kernel <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@osdl.org>
Subject: Re: [PATCH] clean tty fields on failed device open
Date: Wed, 14 Jun 2006 10:49:18 -0300 [thread overview]
Message-ID: <20060614104918.09fc175a@doriath.conectiva> (raw)
In-Reply-To: <20060614115229.GA20751@fks.be>
On Wed, 14 Jun 2006 13:52:30 +0200
Frank Gevaerts <frank.gevaerts@fks.be> wrote:
| On Tue, Jun 13, 2006 at 02:45:12PM -0300, Luiz Fernando N. Capitulino wrote:
| > Could you redo and submit please?
|
| OK. Here it is:
|
| Fixes a BUG on disconnect. gregkh-usb-usb-rmmod-pl2303-after-28.patch (from -mm trees)
| is also needed to fix all problems.
Hmm, I'd prefer something like this:
"""
If either the driver's open() method or try_module_get() fails, we need to
set 'tty->driver_data' and 'port->tty' to NULL in serial_open(), otherwise
we'll get an OOPS in usb_device_disconnect() when the device is disconnected.
"""
--
Luiz Fernando N. Capitulino
next prev parent reply other threads:[~2006-06-14 13:49 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-06-12 20:06 pl2303 ttyUSB0: pl2303_open - failed submitting interrupt urb, error -28 Mark Lord
2006-06-12 20:20 ` Mark Lord
2006-06-12 20:26 ` Lee Revell
2006-06-12 20:41 ` Mark Lord
2006-06-12 20:49 ` Greg KH
2006-06-12 20:56 ` Mark Lord
2006-06-12 21:15 ` Mark Lord
2006-06-12 21:28 ` Greg KH
2006-06-12 21:36 ` Mark Lord
2006-06-12 21:54 ` Mark Lord
2006-06-12 22:03 ` Greg KH
2006-06-12 22:12 ` Mark Lord
2006-06-12 22:23 ` Greg KH
2006-06-12 23:15 ` Mark Lord
2006-06-12 23:21 ` Mark Lord
2006-06-13 11:46 ` Frank Gevaerts
2006-06-13 16:26 ` Luiz Fernando N. Capitulino
2006-06-13 17:45 ` Luiz Fernando N. Capitulino
2006-06-14 11:52 ` [PATCH] clean tty fields on failed device open Frank Gevaerts
2006-06-14 13:49 ` Luiz Fernando N. Capitulino [this message]
2006-06-14 13:52 ` Frank Gevaerts
2006-06-14 14:13 ` Luiz Fernando N. Capitulino
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060614104918.09fc175a@doriath.conectiva \
--to=lcapitulino@mandriva.com.br \
--cc=akpm@osdl.org \
--cc=frank.gevaerts@fks.be \
--cc=gregkh@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=lkml@rtr.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®