mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Al Viro <viro@ftp.linux.org.uk>
To: Linus Torvalds <torvalds@osdl.org>
Cc: linux-kernel@vger.kernel.org, linux-m68k@vger.kernel.org
Subject: [PATCH] m68k: bogus constraints in signal.h
Date: Thu, 15 Jun 2006 12:11:26 +0100	[thread overview]
Message-ID: <20060615111126.GJ27946@ftp.linux.org.uk> (raw)

bfset and friends need "o", not "m" - they don't work with autodecrement
memory arguments.  bitops.h had it fixed, signal.h hadn't...

Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>

---

 include/asm-m68k/signal.h |    6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)

904a77fc8bfa159204cc895d672096e5d3a5a46e
diff --git a/include/asm-m68k/signal.h b/include/asm-m68k/signal.h
index b7b7ea2..f645162 100644
--- a/include/asm-m68k/signal.h
+++ b/include/asm-m68k/signal.h
@@ -156,13 +156,13 @@ #define __HAVE_ARCH_SIG_BITOPS
 
 static inline void sigaddset(sigset_t *set, int _sig)
 {
-	__asm__("bfset %0{%1,#1}" : "=m" (*set) : "id" ((_sig - 1) ^ 31)
+	__asm__("bfset %0{%1,#1}" : "=o" (*set) : "id" ((_sig - 1) ^ 31)
 		: "cc");
 }
 
 static inline void sigdelset(sigset_t *set, int _sig)
 {
-	__asm__("bfclr %0{%1,#1}" : "=m"(*set) : "id"((_sig - 1) ^ 31)
+	__asm__("bfclr %0{%1,#1}" : "=o"(*set) : "id"((_sig - 1) ^ 31)
 		: "cc");
 }
 
@@ -176,7 +176,7 @@ static inline int __gen_sigismember(sigs
 {
 	int ret;
 	__asm__("bfextu %1{%2,#1},%0"
-		: "=d"(ret) : "m"(*set), "id"((_sig-1) ^ 31));
+		: "=d"(ret) : "o"(*set), "id"((_sig-1) ^ 31));
 	return ret;
 }
 
-- 
1.3.GIT


             reply	other threads:[~2006-06-15 11:11 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-06-15 11:11 Al Viro [this message]
2006-06-15 11:46 ` Roman Zippel
2006-06-15 12:03   ` Al Viro
2006-06-15 12:20     ` Roman Zippel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060615111126.GJ27946@ftp.linux.org.uk \
    --to=viro@ftp.linux.org.uk \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-m68k@vger.kernel.org \
    --cc=torvalds@osdl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®