mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Nathan Scott <nathans@sgi.com>
To: Al Viro <viro@ftp.linux.org.uk>
Cc: linux-kernel@vger.kernel.org, Linus Torvalds <torvalds@osdl.org>,
	Christoph Hellwig <hch@lst.de>
Subject: Re: [PATCH] xfs semaphore count abuse fixes
Date: Fri, 16 Jun 2006 10:18:55 +1000	[thread overview]
Message-ID: <20060616101855.B915318@wobbly.melbourne.sgi.com> (raw)
In-Reply-To: <20060615113821.GO27946@ftp.linux.org.uk>; from viro@ftp.linux.org.uk on Thu, Jun 15, 2006 at 12:38:21PM +0100

On Thu, Jun 15, 2006 at 12:38:21PM +0100, Al Viro wrote:
> Kill direct access to ->count in valusema(); all we ever use it for is check
> if semaphore is actually locked, which can be trivially done in portable way.
> Code gets more reabable, while we are at it...

Thanks Al, looks good.  The naming convention you've picked is a
bit inconsistent with the rest of the code there (lacks an "a"),
I'll update it and get it merged.

cheers.

-- 
Nathan

      reply	other threads:[~2006-06-16  0:19 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-06-15 11:38 Al Viro
2006-06-16  0:18 ` Nathan Scott [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060616101855.B915318@wobbly.melbourne.sgi.com \
    --to=nathans@sgi.com \
    --cc=hch@lst.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=torvalds@osdl.org \
    --cc=viro@ftp.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®