From: Christoph Hellwig <hch@infradead.org>
To: Andreas Mohr <andi@rhlx01.fht-esslingen.de>
Cc: Andrew Morton <akpm@osdl.org>,
Nick Piggin <nickpiggin@yahoo.com.au>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH -mm] tasklet_unlock_wait() cpu_relax()
Date: Fri, 16 Jun 2006 14:48:29 +0100 [thread overview]
Message-ID: <20060616134829.GA12657@infradead.org> (raw)
In-Reply-To: <20060614192920.GD19938@rhlx01.fht-esslingen.de>
On Wed, Jun 14, 2006 at 09:29:20PM +0200, Andreas Mohr wrote:
> Hi all,
>
> use cpu_relax() here, too (instead of barrier()).
>
> Signed-off-by: Andreas Mohr <andi@lisas.de>
>
>
> diff -urN linux-2.6.17-rc6-mm2.orig/include/linux/interrupt.h linux-2.6.17-rc6-mm2.my/include/linux/interrupt.h
> --- linux-2.6.17-rc6-mm2.orig/include/linux/interrupt.h 2006-06-13 19:28:16.000000000 +0200
> +++ linux-2.6.17-rc6-mm2.my/include/linux/interrupt.h 2006-06-14 20:35:49.000000000 +0200
> @@ -227,7 +227,7 @@
>
> static inline void tasklet_unlock_wait(struct tasklet_struct *t)
> {
> - while (test_bit(TASKLET_STATE_RUN, &(t)->state)) { barrier(); }
> + while (test_bit(TASKLET_STATE_RUN, &(t)->state)) { cpu_relax(); }
> }
While you're at it could you reformat it to proper kernel style, e.g.:
static inline void tasklet_unlock_wait(struct tasklet_struct *t)
{
while (test_bit(TASKLET_STATE_RUN, &t->state))
cpu_relax();
}
prev parent reply other threads:[~2006-06-16 13:48 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-06-14 19:29 Andreas Mohr
2006-06-15 15:34 ` Arjan van de Ven
2006-06-16 13:48 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060616134829.GA12657@infradead.org \
--to=hch@infradead.org \
--cc=akpm@osdl.org \
--cc=andi@rhlx01.fht-esslingen.de \
--cc=linux-kernel@vger.kernel.org \
--cc=nickpiggin@yahoo.com.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®