mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@osdl.org>
To: "Randy.Dunlap" <rdunlap@xenotime.net>
Cc: sturmflut@lieberbiber.de, linux-kernel@vger.kernel.org, mingo@elte.hu
Subject: Re: [patch 2/3] vdso: improve print_fatal_signals support by adding memory maps
Date: Sat, 17 Jun 2006 22:58:13 -0700	[thread overview]
Message-ID: <20060617225813.1f0fbe15.akpm@osdl.org> (raw)
In-Reply-To: <20060617215818.7bc728af.rdunlap@xenotime.net>

On Sat, 17 Jun 2006 21:58:18 -0700
"Randy.Dunlap" <rdunlap@xenotime.net> wrote:

> On Sat, 17 Jun 2006 16:14:52 +0200 Simon Raffeiner wrote:
> 
> > When compiling 2.6.17-rc6-mm2 (which contains this patch) my gcc 4.0.3 (Ubuntu 
> > 4.0.3-1ubuntu5) complains about "int len;" being used uninitialized in 
> > print_vma(). AFAICS len is not initialized and then passed to 
> > pad_len_spaces(int len), which uses it for some calculations.
> > 
> > I also noticed that similar code is used in fs/proc/task_mmu.c, where 
> > show_map_internal() passes an uninitialised int len; to pad_len_spaces(struct 
> > seq_file *m, int len).
> 
> Ack both of those.  And both of them pass &len as a parameter to
> printk/seq_printf where it looks as though they want just <len>
> (after it has been initialized).
> 

printk("%n", &len) will initialise `len'.  gcc is being wrong again.

  reply	other threads:[~2006-06-18  5:58 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-06-17 14:14 Simon Raffeiner
2006-06-18  4:58 ` Randy.Dunlap
2006-06-18  5:58   ` Andrew Morton [this message]
2006-06-18 13:25     ` Simon Raffeiner
2006-06-18 17:42       ` Randy.Dunlap
2006-06-18 18:29         ` Simon Raffeiner
2006-06-18 18:38           ` Randy.Dunlap
  -- strict thread matches above, loose matches on Subject: below --
2006-05-23  0:01 Ingo Molnar
2006-05-23 22:26 ` Zachary Amsden
2006-05-24  5:34   ` Ingo Molnar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060617225813.1f0fbe15.akpm@osdl.org \
    --to=akpm@osdl.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=rdunlap@xenotime.net \
    --cc=sturmflut@lieberbiber.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®