Re: [patch 2.6.16-rc6-mm2] x86: add NUMA to oops messages

[Chuck Ebbert <76306.1226@compuserve.com>]

In-Reply-To: <200606181059.44576.ak@suse.de>

On Sun, 18 Jun 2006 10:59:44 +0200, Andi Kleen wrote:

> On Sunday 18 June 2006 10:13, Chuck Ebbert wrote:
> > Add "NUMA" to x86 oops printouts to help with debugging.  Use vermagic.h
> > defines to clean up the code, suggested by Arjan van de Ven.
> 
> I don't see any particular value in printing NUMA here,

It helps a lot when trying to decode oopses posted to the list, as the
NUMA kernel is very different now that the slab allocator and scheduler
are NUMA-aware.

 $ fgrep 'def CONFIG_NUMA' mm/*.c kernel/*.c include/linux/* | wc -l
 58
 $ fgrep 'def CONFIG_SMP' mm/*.c kernel/*.c include/linux/* | wc -l
 81

> and putting half of .config into the oops doesn't seem
> like a good long term strategy.

It's just this one thing; I can't think of anything else to add...

-- 
Chuck
 "You can't read a newspaper if you can't read."  --George W. Bush