From: Roland McGrath <roland@redhat.com>
To: Oleg Nesterov <oleg@tv-sign.ru>
Cc: Linus Torvalds <torvalds@osdl.org>, Andrew Morton <akpm@osdl.org>,
john stultz <johnstul@us.ibm.com>,
Thomas Gleixner <tglx@linutronix.de>, Ingo Molnar <mingo@elte.hu>,
Steven Rostedt <rostedt@goodmis.org>,
Chris Wright <chrisw@osdl.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/3] arm_timer: remove a racy and obsolete PF_EXITING check
Date: Mon, 19 Jun 2006 01:06:56 -0700 (PDT) [thread overview]
Message-ID: <20060619080656.42097180049@magilla.sf.frob.com> (raw)
In-Reply-To: Oleg Nesterov's message of Thursday, 15 June 2006 20:12:02 +0400 <20060615161202.GA21463@oleg>
I think this and your other two patches are fine fixes. Thanks, Oleg.
> However, for some reason it does so only for CPUCLOCK_PERTHREAD
> case (which is imho wrong).
For a process CPU clock timer, ->it.cpu.task is the thread group leader.
The group leader can exit and will be a lingering zombie for as long as
other threads in the group live. The process timers need to keep getting
armed and working both during and after the group leader's exit processing.
> Also, this check is not reliable, PF_EXITING could be set on
> another cpu without any locks/barriers just after the check,
> so it can't prevent from attaching the timer to the exiting
> task.
>
> The previous patch makes this check unneeded.
Thanks for cleaning that up. The original rationale behind the checking
for exiting threads was an attempt to avoid process_timer_rebalance
counting a dead thread as live and setting all the live threads' expiry
timers too short, as well as avoiding setting it_*_expires after do_exit
cleared them. The latter didn't suffice anyway and you've fixed it another
way. The former doesn't really do any harm, since it just means a
possibility of early wakeup and recheck in the remaining live threads.
Thanks,
Roland
next prev parent reply other threads:[~2006-06-19 8:07 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-06-15 16:12 Oleg Nesterov
2006-06-19 8:06 ` Roland McGrath [this message]
2006-06-19 23:28 ` Oleg Nesterov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060619080656.42097180049@magilla.sf.frob.com \
--to=roland@redhat.com \
--cc=akpm@osdl.org \
--cc=chrisw@osdl.org \
--cc=johnstul@us.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=oleg@tv-sign.ru \
--cc=rostedt@goodmis.org \
--cc=tglx@linutronix.de \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®