From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751288AbWFSS1q (ORCPT ); Mon, 19 Jun 2006 14:27:46 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751292AbWFSS1q (ORCPT ); Mon, 19 Jun 2006 14:27:46 -0400 Received: from perninha.conectiva.com.br ([200.140.247.100]:29930 "EHLO perninha.conectiva.com.br") by vger.kernel.org with ESMTP id S1751288AbWFSS1p (ORCPT ); Mon, 19 Jun 2006 14:27:45 -0400 Date: Mon, 19 Jun 2006 15:27:42 -0300 From: "Luiz Fernando N. Capitulino" To: Frank Gevaerts Cc: linux-kernel@vger.kernel.org, Greg KH , Andrew Morton Subject: Re: [RESEND] [PATCH 2/2] ipaq.c timing parameters Message-ID: <20060619152742.79e51c67@doriath.conectiva> In-Reply-To: <20060619173428.GD32484@fks.be> References: <20060619084446.GA17103@fks.be> <20060619084619.GB17103@fks.be> <20060619134240.68785a33@doriath.conectiva> <20060619173428.GD32484@fks.be> Organization: Mandriva X-Mailer: Sylpheed-Claws 2.3.0 (GTK+ 2.9.3; i586-mandriva-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 19 Jun 2006 19:34:28 +0200 Frank Gevaerts wrote: | On Mon, Jun 19, 2006 at 01:42:40PM -0300, Luiz Fernando N. Capitulino wrote: | > On Mon, 19 Jun 2006 10:46:19 +0200 | > Frank Gevaerts wrote: | > | > | Adds configurable waiting periods to the ipaq connection code. These are | > | not needed when the pocketpc device is running normally when plugged in, | > | but they need extra delays if they are physically connected while | > | rebooting. | > | There are two parameters : | > | * initial_wait : this is the delay before the driver attemts to start the | > | connection. This is needed because the pocktpc device takes much | > | longer to boot if the driver starts sending control packets too soon. | > | * connect_retries : this is the number of times the control urb is | > | retried before finally giving up. The patch also adds a 1 second delay | > | between retries. | > | I'm not sure if the cases where this patch is useful are general enough | > | to include this in the kernel. | > | | > | Signed-off-by: Frank Gevaerts | > | | > | diff -urp linux-2.6.17-rc6.a/drivers/usb/serial/ipaq.c linux-2.6.17-rc6.b/drivers/usb/serial/ipaq.c | > | --- linux-2.6.17-rc6.a/drivers/usb/serial/ipaq.c 2006-06-14 16:02:03.000000000 +0200 | > | +++ linux-2.6.17-rc6.b/drivers/usb/serial/ipaq.c 2006-06-14 16:06:44.000000000 +0200 | > | @@ -71,6 +71,8 @@ | > | | > | static __u16 product, vendor; | > | static int debug; | > | +static int connect_retries = KP_RETRIES; | > | +static int initial_wait; | > | | > | /* Function prototypes for an ipaq */ | > | static int ipaq_open (struct usb_serial_port *port, struct file *filp); | > | @@ -583,7 +585,7 @@ static int ipaq_open(struct usb_serial_p | > | struct ipaq_private *priv; | > | struct ipaq_packet *pkt; | > | int i, result = 0; | > | - int retries = KP_RETRIES; | > | + int retries = connect_retries; | > | | > | dbg("%s - port %d", __FUNCTION__, port->number); | > | | > | @@ -647,6 +649,7 @@ static int ipaq_open(struct usb_serial_p | > | port->read_urb->transfer_buffer_length = URBDATA_SIZE; | > | port->bulk_out_size = port->write_urb->transfer_buffer_length = URBDATA_SIZE; | > | | > | + msleep(1000*initial_wait); | > | > I was going to say you should use ssleep() here, but I can't find a | > ssleep_interruptible(). Then either: use msleep_interruptible() or | > creates a new ssleep_interruptible(). | | I wasn't sure if that was safe here, so I used the non-interruptible | version. I'll change it when I redo the patch. | Is it worth it creating ssleep_interruptible() just for this one call? You could grep around to check it. -- Luiz Fernando N. Capitulino