From: Theodore Tso <tytso@thunk.org>
To: linux-kernel@vger.kernel.org
Subject: [RFC] [PATCH 8/8] inode-diet: Fix size of i_blkbits, i_version, and i_dnotify_mask
Date: Mon, 19 Jun 2006 11:20:11 -0400 [thread overview]
Message-ID: <20060619153110.629047000@candygram.thunk.org> (raw)
In-Reply-To: <20060619152003.830437000@candygram.thunk.org>
[-- Attachment #1: inode-slim-8 --]
[-- Type: text/plain, Size: 1400 bytes --]
i_blkbits stores the log n of the blocksize; there is no reason for it
to take more than 16 bits, so change it to be a short and put it next
to i_mode.
i_version and i_dnotify_mask need to be 32 bits, but there is no
reason for them to be 64-bit values on 64-bit architectures, so make
them be unsigned int's instead of unsigned long's.
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
Index: linux-2.6.17/include/linux/fs.h
===================================================================
--- linux-2.6.17.orig/include/linux/fs.h 2006-06-19 07:29:36.000000000 -0400
+++ linux-2.6.17/include/linux/fs.h 2006-06-19 07:48:02.000000000 -0400
@@ -483,6 +483,7 @@
unsigned long i_ino;
atomic_t i_count;
umode_t i_mode;
+ unsigned short i_blkbits;
unsigned int i_nlink;
uid_t i_uid;
gid_t i_gid;
@@ -490,8 +491,7 @@
struct timespec i_atime;
struct timespec i_mtime;
struct timespec i_ctime;
- unsigned int i_blkbits;
- unsigned long i_version;
+ unsigned int i_version;
spinlock_t i_lock; /* i_blocks, i_bytes, maybe i_size */
struct mutex i_mutex;
struct rw_semaphore i_alloc_sem;
@@ -523,7 +523,7 @@
__u32 i_generation;
#ifdef CONFIG_DNOTIFY
- unsigned long i_dnotify_mask; /* Directory notify events */
+ unsigned int i_dnotify_mask; /* Directory notify events */
struct dnotify_struct *i_dnotify; /* for directory notifications */
#endif
--
next prev parent reply other threads:[~2006-06-19 15:32 UTC|newest]
Thread overview: 47+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-06-19 15:20 [RFC] [PATCH 0/8] Inode slimming Theodore Tso
2006-06-19 15:20 ` [RFC] [PATCH 1/8] inode_diet: Replace inode.u.generic_ip with inode.i_private Theodore Tso
2006-06-19 17:17 ` Jan Engelhardt
2006-06-19 19:09 ` Christoph Hellwig
2006-06-19 19:37 ` Theodore Tso
2006-06-20 9:43 ` Steven Whitehouse
2006-06-20 11:45 ` Arnd Bergmann
2006-06-20 12:34 ` Steven Whitehouse
2006-06-20 13:53 ` Arnd Bergmann
2006-06-20 15:01 ` Brian F. G. Bidulock
2006-06-20 15:04 ` Brian F. G. Bidulock
2006-06-20 12:29 ` Theodore Tso
2006-06-19 15:20 ` [RFC] [PATCH 2/8] inode-diet: Move i_pipe into a union Theodore Tso
2006-06-19 17:19 ` Jan Engelhardt
2006-06-19 19:06 ` Theodore Tso
2006-06-20 15:23 ` Brian F. G. Bidulock
2006-06-21 1:45 ` Theodore Tso
2006-06-22 9:03 ` Brian F. G. Bidulock
2006-06-19 15:20 ` [RFC] [PATCH 3/8] inode-diet: Move i_bdev " Theodore Tso
2006-06-19 15:20 ` [RFC] [PATCH 4/8] inode-diet: Move i_cdev " Theodore Tso
2006-06-19 17:20 ` Jan Engelhardt
2006-06-19 15:20 ` [RFC] [PATCH 5/8] inode-diet: Eliminate i_blksize and use a per-superblock default Theodore Tso
2006-06-19 15:49 ` Avi Kivity
2006-06-19 16:55 ` Theodore Tso
2006-06-19 15:58 ` Christoph Hellwig
2006-06-19 16:16 ` Joel Becker
2006-06-19 17:20 ` Theodore Tso
2006-06-19 18:55 ` Christoph Hellwig
2006-06-19 22:13 ` Mark Fasheh
2006-06-21 19:41 ` Nate Diller
2006-06-19 17:03 ` Theodore Tso
2006-06-19 18:56 ` Christoph Hellwig
2006-06-19 16:01 ` Joel Becker
2006-06-19 17:06 ` Theodore Tso
2006-06-19 21:45 ` Joel Becker
2006-06-19 22:14 ` Mark Fasheh
2006-06-19 15:20 ` [RFC] [PATCH 6/8] inode-diet: Move i_cindex from struct inode to struct file Theodore Tso
2006-06-19 19:33 ` Al Viro
2006-06-19 19:37 ` Al Viro
2006-06-19 20:58 ` Theodore Tso
2006-06-19 21:51 ` Stefan Richter
2006-06-19 15:20 ` [RFC] [PATCH 7/8] inode-diet: Use a union for i_blocks and i_size, i_rdev and i_devices Theodore Tso
2006-06-19 15:20 ` Theodore Tso [this message]
2006-06-19 16:54 ` [RFC] [PATCH 0/8] Inode slimming Christoph Lameter
2006-06-19 19:09 ` Theodore Tso
2006-06-21 12:51 [RFC] [PATCH 0/8] Inode diet v2 Theodore Tso
2006-06-21 12:51 ` [RFC] [PATCH 8/8] inode-diet: Fix size of i_blkbits, i_version, and i_dnotify_mask Theodore Tso
[not found] ` <200606212335.00176.arnd@arndb.de>
2006-06-22 3:11 ` Theodore Tso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060619153110.629047000@candygram.thunk.org \
--to=tytso@thunk.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®