From: Dominik Brodowski <linux@dominikbrodowski.net>
To: Thomas Gleixner <tglx@timesys.com>, len.brown@intel.com
Cc: Con Kolivas <kernel@kolivas.org>, Ingo Molnar <mingo@elte.hu>,
LKML <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@osdl.org>, john stultz <johnstul@us.ibm.com>
Subject: [1/4] ACPI C-States: accounting of sleep states
Date: Mon, 19 Jun 2006 23:28:52 +0200 [thread overview]
Message-ID: <20060619212852.GA12338@dominikbrodowski.de> (raw)
In-Reply-To: <20060619205718.GA26332@isilmar.linta.de>
Track the actual time spent in C-States (C2 upwards, we can't
determine this for C1), not only the number of invocations. This is
especially useful for dynamic ticks / "tickless systems", but is also
of interest on normal systems, as any interrupt activity leads to
C-States being exited, not only the timer interrupt.
The time is being measured in PM timer ticks, so an increase by one equals
279 nanoseconds.
Signed-off-by: Dominik Brodowski <linux@dominikbrodowski.net>
---
drivers/acpi/processor_idle.c | 10 ++++++----
include/acpi/processor.h | 1 +
2 files changed, 7 insertions(+), 4 deletions(-)
3997a08ff5aa0553dfff81801c3690a5c91ac7bc
diff --git a/drivers/acpi/processor_idle.c b/drivers/acpi/processor_idle.c
index 80fa434..4f166fa 100644
--- a/drivers/acpi/processor_idle.c
+++ b/drivers/acpi/processor_idle.c
@@ -322,8 +322,6 @@ static void acpi_processor_idle(void)
cx = &pr->power.states[ACPI_STATE_C1];
#endif
- cx->usage++;
-
/*
* Sleep:
* ------
@@ -421,6 +419,9 @@ static void acpi_processor_idle(void)
local_irq_enable();
return;
}
+ cx->usage++;
+ if ((cx->type != ACPI_STATE_C1) && (sleep_ticks > 0))
+ cx->time += sleep_ticks;
next_state = pr->power.state;
@@ -1055,9 +1056,10 @@ static int acpi_processor_power_seq_show
else
seq_puts(seq, "demotion[--] ");
- seq_printf(seq, "latency[%03d] usage[%08d]\n",
+ seq_printf(seq, "latency[%03d] usage[%08d] duration[%020llu]\n",
pr->power.states[i].latency,
- pr->power.states[i].usage);
+ pr->power.states[i].usage,
+ pr->power.states[i].time);
}
end:
diff --git a/include/acpi/processor.h b/include/acpi/processor.h
index badf027..ca0e031 100644
--- a/include/acpi/processor.h
+++ b/include/acpi/processor.h
@@ -51,6 +51,7 @@ struct acpi_processor_cx {
u32 latency_ticks;
u32 power;
u32 usage;
+ u64 time;
struct acpi_processor_cx_policy promotion;
struct acpi_processor_cx_policy demotion;
};
--
1.2.4
next prev parent reply other threads:[~2006-06-19 21:36 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-06-18 15:10 [PATCHSET] Announce: High-res timers, tickless/dyntick and dynamic HZ Thomas Gleixner
2006-06-18 16:35 ` Michal Piotrowski
2006-06-18 18:28 ` Ingo Molnar
2006-06-19 16:35 ` Michal Piotrowski
2006-06-19 19:51 ` Thomas Gleixner
2006-06-25 13:06 ` Steven Rostedt
2006-06-25 14:26 ` Thomas Gleixner
2006-06-18 19:50 ` Thomas Gleixner
2006-06-19 12:09 ` Con Kolivas
2006-06-19 12:31 ` Thomas Gleixner
2006-06-19 13:05 ` Con Kolivas
2006-06-19 13:10 ` Thomas Gleixner
2006-06-19 21:58 ` mark gross
2006-06-19 22:19 ` Thomas Gleixner
2006-06-21 12:54 ` Felix Oxley
2006-06-21 13:07 ` Thomas Gleixner
2006-06-18 23:47 ` Roman Zippel
2006-06-19 12:50 ` Ingo Molnar
2006-06-19 13:47 ` Roman Zippel
2006-06-19 5:21 ` Con Kolivas
2006-06-19 5:24 ` Con Kolivas
2006-06-19 12:26 ` Ingo Molnar
2006-06-19 14:03 ` Con Kolivas
2006-06-19 20:06 ` Thomas Gleixner
2006-06-19 20:57 ` ACPI C-States algorithm updates for dyn-tick Dominik Brodowski
2006-06-19 21:28 ` Dominik Brodowski [this message]
2006-06-19 21:29 ` [2/4] ACPI C-States: bm_activity improvements Dominik Brodowski
2006-06-19 21:31 ` [3/4] ACPI C-States: only demote on current bus mastering activity Dominik Brodowski
2006-06-19 21:33 ` [4/4 -- only for discussion] ACPI C-States: dyn-ticks-improvements (for -ck implementation) Dominik Brodowski
2006-06-28 7:27 [1/4] ACPI C-States: accounting of sleep states Brown, Len
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060619212852.GA12338@dominikbrodowski.de \
--to=linux@dominikbrodowski.net \
--cc=akpm@osdl.org \
--cc=johnstul@us.ibm.com \
--cc=kernel@kolivas.org \
--cc=len.brown@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=tglx@timesys.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®