From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1030183AbWFTIye (ORCPT ); Tue, 20 Jun 2006 04:54:34 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S965076AbWFTIyd (ORCPT ); Tue, 20 Jun 2006 04:54:33 -0400 Received: from cavan.codon.org.uk ([217.147.92.49]:58800 "EHLO vavatch.codon.org.uk") by vger.kernel.org with ESMTP id S965068AbWFTIyc (ORCPT ); Tue, 20 Jun 2006 04:54:32 -0400 Date: Tue, 20 Jun 2006 09:54:29 +0100 From: Matthew Garrett To: Andrew Morton Cc: linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org Subject: Re: [PATCH] Clear abnormal poweroff flag on VIA southbridges, fix resume Message-ID: <20060620085429.GB27362@srcf.ucam.org> References: <20060618191421.GA15358@srcf.ucam.org> <20060619230144.155bc938.akpm@osdl.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20060619230144.155bc938.akpm@osdl.org> User-Agent: Mutt/1.5.9i X-SA-Exim-Connect-IP: X-SA-Exim-Mail-From: mjg59@codon.org.uk X-SA-Exim-Scanned: No (on vavatch.codon.org.uk); SAEximRunCond expanded to false Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jun 19, 2006 at 11:01:44PM -0700, Andrew Morton wrote: > Is CONFIG_ACPI the right thing to use here? As opposed to, say, CONFIG_PM? > Or CONFIG_ACPI_SLEEP?? I've implemented it using the acpi register handling code, so CONFIG_ACPI_something makes sense. I believe that the APM bios will handle it itself, but the machine I have doesn't support APM so can't check that. CONFIG_ACPI_SLEEP might be a better choice than CONFIG_ACPI, yes. -- Matthew Garrett | mjg59@srcf.ucam.org