mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@elte.hu>
To: Andrew Morton <akpm@osdl.org>
Cc: ccb@acm.org, linux-kernel@vger.kernel.org,
	Dave Olson <olson@unixfolk.com>
Subject: Re: [patch] fix spinlock-debug looping
Date: Tue, 20 Jun 2006 11:34:33 +0200	[thread overview]
Message-ID: <20060620093433.GB11037@elte.hu> (raw)
In-Reply-To: <20060620023216.4995edb9.akpm@osdl.org>


* Andrew Morton <akpm@osdl.org> wrote:

> > Spinlocks are alot fairer. Or as a simple experiment, 
> > s/read_lock/write_lock, as the patch below (against rc6-mm2) does. 
> > This is phase #1, if it works out we can switch tree_lock to a 
> > spinlock. [write_lock()s are roughly as fair to each other as 
> > spinlocks - it's a bit more expensive but not significantly] Builds 
> > & boots fine here.
> 
> tree_lock was initially an rwlock.  Then we made it a spinlock.  Then 
> we made it an rwlock.  We change the dang thing so often we should 
> make it a macro ;)

ha! In -rt we can change types of locks by changing the type definition 
and the declaration only ;-) [It makes for some confusing reading though 
if done without restraint]

> Let's just make it a spinlock and be done with it.  Hopefully Dave or 
> ccb@acm.org (?) will be able to test it.  I was planning on doing a 
> patch tomorrowish.

ok. Until that happens the patch i sent can be used for testing.

	Ingo

  reply	other threads:[~2006-06-20  9:39 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-06-12 19:53 BUG: write-lock lockup Charles C. Bennett, Jr.
2006-06-17 17:07 ` Andrew Morton
2006-06-19  7:02   ` [patch] increase spinlock-debug looping timeouts from 1 sec to 1 min Ingo Molnar
2006-06-19  7:59     ` Andrew Morton
2006-06-19  8:12       ` Ingo Molnar
2006-06-19  8:21         ` Ingo Molnar
2006-06-19  8:32         ` Andrew Morton
2006-06-19  8:35           ` Ingo Molnar
2006-06-19  9:13             ` Andrew Morton
2006-06-19 11:39               ` Ingo Molnar
2006-06-19 19:55                 ` Andrew Morton
2006-06-20  8:06                   ` Arjan van de Ven
2006-06-20  8:40                   ` [patch] fix spinlock-debug looping Ingo Molnar
2006-06-20  8:52                     ` Andrew Morton
2006-06-20  9:15                       ` Ingo Molnar
2006-06-20  9:32                         ` Andrew Morton
2006-06-20  9:34                           ` Ingo Molnar [this message]
2006-06-20 16:02                           ` Dave Olson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060620093433.GB11037@elte.hu \
    --to=mingo@elte.hu \
    --cc=akpm@osdl.org \
    --cc=ccb@acm.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=olson@unixfolk.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®