mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Randy.Dunlap" <rdunlap@xenotime.net>
To: Edgar Hucek <hostmaster@ed-soft.at>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/1] Fix boot on efi 32 bit Machines
Date: Tue, 20 Jun 2006 10:16:05 -0700	[thread overview]
Message-ID: <20060620101605.0240a685.rdunlap@xenotime.net> (raw)
In-Reply-To: <4497F85B.7010409@ed-soft.at>

On Tue, 20 Jun 2006 15:30:03 +0200 Edgar Hucek wrote:

> Fix EFI boot on 32 bit machines with pcie port.
> Efi machines does not have an e820 memory map.
> 
> Signed-off-by: Edgar Hucek <hostmaster@ed-soft.at>

Darn, I was going to comment on the patch, but the attachment
isn't quoted... :(


1.  if you modify this patch, change
+	if(!efi_enabled) {
to
	if (!efi_enabled) {
to be compatible with Linux coding style.

2.  There are ways to send inline patches with thunderbird.
Take a look at these:
http://mbligh.org/linuxdocs/Email/Clients/Thunderbird
http://lkml.org/lkml/2005/12/27/191
http://lists.osdl.org/pipermail/kernel-janitors/2006-June/006478.html

Thanks,
---
~Randy

  reply	other threads:[~2006-06-20 17:13 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-06-20 13:30 Edgar Hucek
2006-06-20 17:16 ` Randy.Dunlap [this message]
2006-06-20 21:58   ` Jan Engelhardt
2006-06-20 22:26     ` Randy.Dunlap

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060620101605.0240a685.rdunlap@xenotime.net \
    --to=rdunlap@xenotime.net \
    --cc=hostmaster@ed-soft.at \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®