Re: [PATCH] Implement kasprintf

["Randy.Dunlap" <rdunlap@xenotime.net>]

On Tue, 20 Jun 2006 17:14:55 -0700 Jeremy Fitzhardinge wrote:

> Randy.Dunlap wrote:
> > Why do we want a separate source file for this one function?
> >   
> Because if it shared a file with something else, someone would complain 
> about it bloating code which doesn't use it...  At the moment there are 
> no in-tree users (though I'm sure there's something out there with an 
> open-coded version of this), but we'll be needing it for Xen.

Doesn't this already add the bloat/code? ::

diff -r c175fd50e604 lib/Makefile
--- a/lib/Makefile	Tue Jun 20 16:47:53 2006 -0700
+++ b/lib/Makefile	Tue Jun 20 16:53:19 2006 -0700
@@ -5,7 +5,7 @@ lib-y := errno.o ctype.o string.o vsprin
 lib-y := errno.o ctype.o string.o vsprintf.o cmdline.o \
 	 bust_spinlocks.o rbtree.o radix-tree.o dump_stack.o \
 	 idr.o div64.o int_sqrt.o bitmap.o extable.o prio_tree.o \
-	 sha1.o
+	 sha1.o kasprintf.o

> I'm happy to fold it into vsprintf.c though.

That makes sense to me.

Thanks,
---
~Randy