From: Willy Tarreau <w@1wt.eu>
To: linux-kernel@vger.kernel.org
Cc: marcelo@kvack.org, len.brown@intel.com
Subject: [PATCH-2.4] range checking for sleep states sent to /proc/acpi/sleep
Date: Wed, 21 Jun 2006 00:42:43 +0200 [thread overview]
Message-ID: <20060620224243.GB11988@1wt.eu> (raw)
Hi,
A range checking is missing in acpi_system_write_sleep() in kernel
2.4, and writing a large integer value to /proc/acpi/sleep will cause
an oops. I could reproduce one this way :
# echo 0x800000 >/proc/acpi/sleep
Fix extracted from the PaX patch.
Cheers,
Willy
---
drivers/acpi/system.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
3cae76269fd00aa352255d872c8f461472ef8b56
diff --git a/drivers/acpi/system.c b/drivers/acpi/system.c
index a1e018c..26f7b68 100644
--- a/drivers/acpi/system.c
+++ b/drivers/acpi/system.c
@@ -748,7 +748,7 @@ acpi_system_write_sleep (
state = simple_strtoul(state_string, NULL, 0);
- if (!system->states[state])
+ if (state >= ACPI_S_STATE_COUNT || !system->states[state])
return_VALUE(-ENODEV);
/*
--
1.3.3
reply other threads:[~2006-06-20 22:47 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060620224243.GB11988@1wt.eu \
--to=w@1wt.eu \
--cc=len.brown@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=marcelo@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®