From: Chuck Ebbert <76306.1226@compuserve.com>
To: Andreas Mohr <andi@rhlx01.fht-esslingen.de>
Cc: Andrew Morton <akpm@osdl.org>,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [patch] i386: halt the CPU on serious errors
Date: Wed, 21 Jun 2006 05:17:32 -0400 [thread overview]
Message-ID: <200606210520_MC3-1-C307-8E13@compuserve.com> (raw)
In-Reply-To: <20060620075015.GB3030@rhlx01.fht-esslingen.de>
On Tue, 20 Jun 2006 09:50:15 +0200, Andreas Mohr wrote:
> Thanks for the very fast patch, but:
>
> > /* Assume hlt works */
> > - halt();
> > - for(;;);
> > + for (;;)
> > + halt();
>
> The comment above seems to hint at this code in arch/i386/kernel/smp.c/
> stop_this_cpu() which does proper hlt checks:
>
> if (cpu_data[smp_processor_id()].hlt_works_ok)
> for(;;) halt();
> for (;;);
>
> So I'm unsure what happens if hlt is not supported properly. Maybe
> there's an invalid opcode exception in a loop then.
Some ancient CPUs never wake up on interrupt after a halt. See
include/asm-i386/bugs.h::check_hlt().
--
Chuck
"You can't read a newspaper if you can't read." --George W. Bush
next reply other threads:[~2006-06-21 9:21 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-06-21 9:17 Chuck Ebbert [this message]
-- strict thread matches above, loose matches on Subject: below --
2006-06-21 9:17 Chuck Ebbert
2006-06-20 4:55 Chuck Ebbert
2006-06-20 5:09 ` Dave Jones
2006-06-20 7:50 ` Andreas Mohr
2006-06-21 9:20 ` Andi Kleen
2006-06-21 9:26 ` Arjan van de Ven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200606210520_MC3-1-C307-8E13@compuserve.com \
--to=76306.1226@compuserve.com \
--cc=akpm@osdl.org \
--cc=andi@rhlx01.fht-esslingen.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®