From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner+willy=40w.ods.org-S1751462AbWFUVlT@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1751462AbWFUVlT (ORCPT <rfc822;willy@w.ods.org>);
	Wed, 21 Jun 2006 17:41:19 -0400
Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751476AbWFUVlS
	(ORCPT <rfc822;linux-kernel-outgoing>);
	Wed, 21 Jun 2006 17:41:18 -0400
Received: from smtp.osdl.org ([65.172.181.4]:54973 "EHLO smtp.osdl.org")
	by vger.kernel.org with ESMTP id S1751462AbWFUVlP (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Wed, 21 Jun 2006 17:41:15 -0400
Date: Wed, 21 Jun 2006 14:34:50 -0700
From: Andrew Morton <akpm@osdl.org>
To: Mattia Dongili <malattia@linux.it>
Cc: hpa@zytor.com, mbligh@mbligh.org, linux-kernel@vger.kernel.org,
       Chuck Ebbert <76306.1226@compuserve.com>
Subject: Re: fs/binfmt_aout.o, Error: suffix or operands invalid for `cmp'
 [was Re: 2.6.17-mm1]
Message-Id: <20060621143450.41129b01.akpm@osdl.org>
In-Reply-To: <20060621211616.GB4638@inferi.kami.home>
References: <44998DCB.1030703@mbligh.org>
	<20060621184814.GQ24595@inferi.kami.home>
	<44999BC5.7060702@zytor.com>
	<20060621193932.GR24595@inferi.kami.home>
	<20060621134215.1bca6a5c.akpm@osdl.org>
	<20060621211616.GB4638@inferi.kami.home>
X-Mailer: Sylpheed version 2.2.4 (GTK+ 2.8.17; i686-pc-linux-gnu)
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, 21 Jun 2006 23:16:17 +0200
Mattia Dongili <malattia@linux.it> wrote:

> On Wed, Jun 21, 2006 at 01:42:15PM -0700, Andrew Morton wrote:
> > On Wed, 21 Jun 2006 21:39:32 +0200
> > Mattia Dongili <malattia@linux.it> wrote:
> > 
> > > Thanks, this is fixed, but I have a new failure:
> > >   CC [M]  fs/xfs/support/move.o
> > >   CC [M]  fs/xfs/support/uuid.o
> > >   LD [M]  fs/xfs/xfs.o
> > >   CC      fs/dnotify.o
> > >   CC      fs/dcookies.o
> > >   LD      fs/built-in.o
> > >   CC [M]  fs/binfmt_aout.o
> > > {standard input}: Assembler messages:
> > > {standard input}:160: Error: suffix or operands invalid for `cmp'
> > > make[1]: *** [fs/binfmt_aout.o] Error 1
> > > make: *** [fs] Error 2
> > 
> > what the heck?  Can you do `make fs/binfmt_aout.s' then send the relevant
> > parts of that file?
> 
> I can't really tell which is the relevant part other than line 160 :)
> Full file available here:
> http://oioio.altervista.org/linux/binfmt_aout.s
> 

It's complaining about this:

#APP
        addl %ecx,%eax ; sbbl %edx,%edx; cmpl %eax,$-1073741824; sbbl $0,%edx   # dump.u_dsize, sum, flag,
#NO_APP

from fs/binfmt_aout.c:154:

        if (!access_ok(VERIFY_READ, (void __user *)START_DATA(dump), dump.u_dsize << PAGE_SHIFT))
                dump.u_dsize = 0;
        if (!access_ok(VERIFY_READ, (void __user *)START_STACK(dump), dump.u_ssize << PAGE_SHIFT))
                dump.u_ssize = 0;

the offending code comes from __range_ok()

Mad guess: does reverting
ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.17/2.6.17-mm1/broken-out/i386-use-c-code-for-current_thread_info.patch
help?