From: Adrian Bunk <bunk@stusta.de>
To: Andrew Morton <akpm@osdl.org>,
rolandd@cisco.com, linux-driver@qlogic.com
Cc: linux-kernel@vger.kernel.org, openib-general@openib.org,
linux-scsi@vger.kernel.org
Subject: [-mm patch] drivers/scsi/qla2xxx/: make some functions static
Date: Thu, 22 Jun 2006 00:54:58 +0200 [thread overview]
Message-ID: <20060621225458.GQ9111@stusta.de> (raw)
In-Reply-To: <20060621034857.35cfe36f.akpm@osdl.org>
On Wed, Jun 21, 2006 at 03:48:57AM -0700, Andrew Morton wrote:
>...
> Changes since 2.6.17-rc6-mm2:
>...
> git-infiniband.patch
>...
> git trees
>...
This patch makes some needlessly global functions static.
Signed-off-by: Adrian Bunk <bunk@stusta.de>
---
drivers/scsi/qla2xxx/qla_gbl.h | 6 ------
drivers/scsi/qla2xxx/qla_init.c | 8 +++++---
drivers/scsi/qla2xxx/qla_iocb.c | 3 ++-
3 files changed, 7 insertions(+), 10 deletions(-)
--- linux-2.6.17-mm1-full/drivers/scsi/qla2xxx/qla_gbl.h.old 2006-06-22 00:48:35.000000000 +0200
+++ linux-2.6.17-mm1-full/drivers/scsi/qla2xxx/qla_gbl.h 2006-06-22 00:50:32.000000000 +0200
@@ -31,13 +31,9 @@
extern void qla24xx_update_fw_options(scsi_qla_host_t *);
extern int qla2x00_load_risc(struct scsi_qla_host *, uint32_t *);
extern int qla24xx_load_risc(scsi_qla_host_t *, uint32_t *);
-extern int qla24xx_load_risc_flash(scsi_qla_host_t *, uint32_t *);
-
-extern fc_port_t *qla2x00_alloc_fcport(scsi_qla_host_t *, gfp_t);
extern int qla2x00_loop_resync(scsi_qla_host_t *);
-extern int qla2x00_find_new_loop_id(scsi_qla_host_t *, fc_port_t *);
extern int qla2x00_fabric_login(scsi_qla_host_t *, fc_port_t *, uint16_t *);
extern int qla2x00_local_device_login(scsi_qla_host_t *, fc_port_t *);
@@ -80,8 +76,6 @@
/*
* Global Function Prototypes in qla_iocb.c source file.
*/
-extern void qla2x00_isp_cmd(scsi_qla_host_t *);
-
extern uint16_t qla2x00_calc_iocbs_32(uint16_t);
extern uint16_t qla2x00_calc_iocbs_64(uint16_t);
extern void qla2x00_build_scsi_iocbs_32(srb_t *, cmd_entry_t *, uint16_t);
--- linux-2.6.17-mm1-full/drivers/scsi/qla2xxx/qla_init.c.old 2006-06-22 00:48:58.000000000 +0200
+++ linux-2.6.17-mm1-full/drivers/scsi/qla2xxx/qla_init.c 2006-06-22 00:49:50.000000000 +0200
@@ -39,6 +39,8 @@
static int qla2x00_restart_isp(scsi_qla_host_t *);
+static int qla2x00_find_new_loop_id(scsi_qla_host_t *ha, fc_port_t *dev);
+
/****************************************************************************/
/* QLogic ISP2x00 Hardware Support Functions. */
/****************************************************************************/
@@ -1701,7 +1703,7 @@
*
* Returns a pointer to the allocated fcport, or NULL, if none available.
*/
-fc_port_t *
+static fc_port_t *
qla2x00_alloc_fcport(scsi_qla_host_t *ha, gfp_t flags)
{
fc_port_t *fcport;
@@ -2497,7 +2499,7 @@
* Context:
* Kernel context.
*/
-int
+static int
qla2x00_find_new_loop_id(scsi_qla_host_t *ha, fc_port_t *dev)
{
int rval;
@@ -3472,7 +3474,7 @@
return (rval);
}
-int
+static int
qla24xx_load_risc_flash(scsi_qla_host_t *ha, uint32_t *srisc_addr)
{
int rval;
--- linux-2.6.17-mm1-full/drivers/scsi/qla2xxx/qla_iocb.c.old 2006-06-22 00:50:42.000000000 +0200
+++ linux-2.6.17-mm1-full/drivers/scsi/qla2xxx/qla_iocb.c 2006-06-22 00:51:00.000000000 +0200
@@ -15,6 +15,7 @@
static inline cont_entry_t *qla2x00_prep_cont_type0_iocb(scsi_qla_host_t *);
static inline cont_a64_entry_t *qla2x00_prep_cont_type1_iocb(scsi_qla_host_t *);
static request_t *qla2x00_req_pkt(scsi_qla_host_t *ha);
+static void qla2x00_isp_cmd(scsi_qla_host_t *ha);
/**
* qla2x00_get_cmd_direction() - Determine control_flag data direction.
@@ -574,7 +575,7 @@
*
* Note: The caller must hold the hardware lock before calling this routine.
*/
-void
+static void
qla2x00_isp_cmd(scsi_qla_host_t *ha)
{
device_reg_t __iomem *reg = ha->iobase;
next prev parent reply other threads:[~2006-06-21 22:55 UTC|newest]
Thread overview: 130+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-06-21 10:48 2.6.17-mm1 Andrew Morton
2006-06-21 11:07 ` 2.6.17-mm1 Michal Piotrowski
2006-06-21 11:17 ` 2.6.17-mm1 Andrew Morton
2006-06-21 11:29 ` 2.6.17-mm1 Michal Piotrowski
2006-06-21 13:53 ` 2.6.17-mm1 Cedric Le Goater
2006-06-21 14:13 ` 2.6.17-mm1 Michal Piotrowski
2006-06-21 16:44 ` 2.6.17-mm1 H. Peter Anvin
2006-06-21 19:26 ` 2.6.17-mm1 Cedric Le Goater
2006-06-21 21:46 ` 2.6.17-mm1 Michal Piotrowski
2006-06-21 11:28 ` 2.6.17-mm1 Andrew Morton
2006-06-21 15:35 ` 2.6.17-mm1 Christoph Lameter
2006-06-21 12:06 ` 2.6.17-mm1 Michal Piotrowski
2006-06-21 15:10 ` [-mm patch] drivers/net/ni5010.c: fix compile error Adrian Bunk
2006-06-22 8:13 ` Andreas Mohr
2006-06-22 8:45 ` Adrian Bunk
2006-06-21 18:22 ` [PATCH] pi-futex-rt-mutex-core-merge.patch (was Re: 2.6.17-mm1 Valdis.Kletnieks
2006-06-21 21:48 ` swsusp regression [Was: 2.6.17-mm1] Jiri Slaby
2006-06-21 22:14 ` Mattia Dongili
2006-06-21 22:18 ` Mattia Dongili
2006-06-22 6:19 ` [linux-pm] " Greg KH
2006-06-22 7:46 ` Andrew Morton
2006-06-22 8:25 ` Jeremy Fitzhardinge
2006-06-22 15:51 ` Alan Stern
2006-06-22 17:17 ` Jeremy Fitzhardinge
2006-06-22 18:46 ` Greg KH
2006-06-22 19:07 ` Greg KH
2006-06-22 19:57 ` Alan Stern
2006-06-22 20:22 ` Greg KH
2006-06-22 20:38 ` Jiri Slaby
2006-06-22 21:09 ` Alan Stern
2006-06-22 21:11 ` Greg KH
2006-06-22 16:04 ` Frederik Deweerdt
2006-06-22 16:25 ` Andrew Morton
2006-06-22 19:07 ` Frederik Deweerdt
2006-06-23 9:02 ` Frederik Deweerdt
2006-06-23 9:10 ` Pavel Machek
2006-06-23 9:31 ` Andrew Morton
2006-06-23 12:12 ` Frederik Deweerdt
2006-06-23 12:57 ` Pavel Machek
2006-06-23 13:47 ` Frederik Deweerdt
2006-06-23 19:57 ` Andrew Morton
2006-06-26 9:00 ` Frederik Deweerdt
2006-06-23 19:41 ` Russell King
2006-06-23 20:22 ` Dave Jones
2006-06-23 21:10 ` Rafael J. Wysocki
2006-06-23 22:11 ` Pavel Machek
2006-06-23 23:53 ` Frederik Deweerdt
2006-06-24 17:16 ` Rafael J. Wysocki
2006-06-21 21:57 ` [-mm patch] drivers/acpi/scan.c: make acpi_bus_type static Adrian Bunk
2006-06-21 21:57 ` [-mm patch] drivers/ide/legacy/ide-cs.c: make 2 functions static Adrian Bunk
2006-06-21 21:57 ` [-mm patch] drivers/md/md.c: make code static Adrian Bunk
2006-06-21 21:57 ` [-mm patch] drivers/media/video/vivi.c: make 2 functions static Adrian Bunk
2006-06-21 21:57 ` [-mm patch] gpio: make two mutexes static again Adrian Bunk
2006-06-21 22:54 ` Adrian Bunk [this message]
2006-06-21 23:20 ` [-mm patch] make drivers/scsi/pata_pcmcia.c:pcmcia_remove_one() static Adrian Bunk
2006-06-22 10:50 ` Alan Cox
2006-06-21 23:37 ` [-mm patch] make drivers/usb/misc/cy7c63.c:vendor_command() static Adrian Bunk
2006-06-21 23:39 ` 2.6.17-mm1 : two PF flags with the same value Peter Williams
2006-06-21 23:44 ` Andrew Morton
2006-06-22 0:12 ` Paul Jackson
2006-06-22 10:03 ` [-mm patch] #if 0 drivers/usb/input/hid-core.c:hid_find_field_by_usage() Adrian Bunk
2006-06-22 10:03 ` [-mm patch] fs/gfs2/: make code static Adrian Bunk
2006-06-22 10:25 ` Steven Whitehouse
2006-06-22 14:58 ` 2.6.17-mm1 Franck Bui-Huu
2006-06-22 15:20 ` 2.6.17-mm1 Mel Gorman
2006-06-22 15:50 ` 2.6.17-mm1 Franck Bui-Huu
2006-06-22 15:54 ` 2.6.17-mm1 Mel Gorman
2006-06-22 16:14 ` 2.6.17-mm1 Russell King
2006-06-22 16:50 ` 2.6.17-mm1 Mel Gorman
2006-06-22 17:25 ` 2.6.17-mm1 Franck Bui-Huu
2006-06-23 10:20 ` 2.6.17-mm1 Mel Gorman
2006-06-23 12:22 ` 2.6.17-mm1 Franck Bui-Huu
2006-06-23 12:56 ` 2.6.17-mm1 Franck Bui-Huu
2006-06-23 13:46 ` 2.6.17-mm1 Mel Gorman
2006-06-23 14:52 ` 2.6.17-mm1 Franck Bui-Huu
2006-06-23 15:06 ` 2.6.17-mm1 Franck Bui-Huu
2006-06-23 15:13 ` 2.6.17-mm1 Mel Gorman
2006-06-23 15:51 ` 2.6.17-mm1 Franck Bui-Huu
2006-06-23 16:38 ` 2.6.17-mm1 Mel Gorman
2006-06-26 8:31 ` 2.6.17-mm1 Franck Bui-Huu
2006-06-26 10:37 ` 2.6.17-mm1 Mel Gorman
2006-06-26 11:31 ` 2.6.17-mm1 Franck Bui-Huu
2006-06-26 13:22 ` 2.6.17-mm1 Mel Gorman
2006-06-26 13:49 ` 2.6.17-mm1 Franck Bui-Huu
2006-06-26 14:31 ` 2.6.17-mm1 Mel Gorman
2006-06-26 15:05 ` 2.6.17-mm1 Franck Bui-Huu
2006-06-26 15:15 ` 2.6.17-mm1 Mel Gorman
2006-06-23 15:14 ` 2.6.17-mm1 Franck Bui-Huu
2006-06-23 19:55 ` 2.6.17-mm1 Russell King
2006-06-22 15:52 ` 2.6.17-mm1: kernel/lockdep.c: write-only variables Adrian Bunk
2006-06-23 7:26 ` Ingo Molnar
2006-06-23 7:49 ` Ingo Molnar
2006-06-22 21:34 ` 2.6.17-mm1: UML failing w/o SKAS enabled Theodore Tso
2006-06-22 21:57 ` Andrew Morton
2006-06-23 2:54 ` Jeff Dike
2006-06-23 10:10 ` Roman Zippel
2006-06-23 14:28 ` Jeff Dike
2006-06-26 11:52 ` Roman Zippel
2006-06-29 21:13 ` Jeff Dike
2006-06-23 2:42 ` Jeff Dike
2006-06-23 21:07 ` Theodore Tso
2006-06-23 21:46 ` Jeff Dike
2006-06-24 12:43 ` Theodore Tso
2006-06-24 15:18 ` Jeff Dike
2006-06-24 14:00 ` Theodore Tso
2006-06-24 15:22 ` Jeff Dike
2006-06-24 15:38 ` Theodore Tso
2006-06-24 16:06 ` Thomas Gleixner
2006-06-25 16:08 ` Jeff Dike
2006-06-23 10:55 ` [-mm patch] fs/reiser4/: possible cleanups Adrian Bunk
2006-06-23 15:54 ` Hans Reiser
2006-06-23 10:55 ` [-mm patch] fs/ufs/inode.c: make 2 functions static Adrian Bunk
2006-06-23 10:55 ` [-mm patch] make ipc/sem.c:exit_sem() static Adrian Bunk
2006-06-23 10:55 ` [-mm patch] kernel/lockdep.c: make 3 functions static Adrian Bunk
2006-06-23 11:08 ` Ingo Molnar
2006-06-23 10:55 ` [-mm patch] drivers/char/agp/nvidia-agp.c: remove unused variable Adrian Bunk
2006-06-23 10:55 ` [-mm patch] make kernel/sysctl.c:_proc_do_string() static Adrian Bunk
2006-06-23 10:55 ` [-mm patch] make kernel/utsname.c:clone_uts_ns() Adrian Bunk
2006-06-23 16:35 ` Serge E. Hallyn
2006-06-23 10:56 ` [-mm patch] mm/readahead.c: cleanups Adrian Bunk
2006-06-24 6:00 ` Andrew Morton
2006-06-23 12:33 ` 2.6.17-mm1 Michal Piotrowski
2006-06-23 20:42 ` 2.6.17-mm1 Andrew Morton
2006-06-23 15:48 ` 2.6.17-mm1 Eduard Bloch
2006-06-23 16:42 ` 2.6.17-mm1 Jiri Slaby
2006-06-23 20:39 ` 2.6.17-mm1 Keith Mannthey
2006-06-23 21:32 ` 2.6.17-mm1 Andrew Morton
2006-06-24 21:27 ` 2.6.17-mm1 Sam Ravnborg
2006-06-24 21:53 ` 2.6.17-mm1 Andrew Morton
2006-07-02 18:54 ` 2.6.17-mm1 Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060621225458.GQ9111@stusta.de \
--to=bunk@stusta.de \
--cc=akpm@osdl.org \
--cc=linux-driver@qlogic.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=openib-general@openib.org \
--cc=rolandd@cisco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome