From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932536AbWFVJCz (ORCPT ); Thu, 22 Jun 2006 05:02:55 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S932531AbWFVJCz (ORCPT ); Thu, 22 Jun 2006 05:02:55 -0400 Received: from rhun.apana.org.au ([64.62.148.172]:14854 "EHLO arnor.apana.org.au") by vger.kernel.org with ESMTP id S932527AbWFVJCy (ORCPT ); Thu, 22 Jun 2006 05:02:54 -0400 Date: Thu, 22 Jun 2006 19:02:27 +1000 To: Jeff Garzik Cc: Alan Cox , snakebyte@gmx.de, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, davem@davemloft.net Subject: Re: Memory corruption in 8390.c ? (was Re: Possible leaks in network drivers) Message-ID: <20060622090227.GA28367@gondor.apana.org.au> References: <1150909982.15275.100.camel@localhost.localdomain> <20060622023029.GA6156@gondor.apana.org.au> <449A533E.4090201@pobox.com> <20060622082931.GA26083@gondor.apana.org.au> <449A5B83.4090104@pobox.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <449A5B83.4090104@pobox.com> User-Agent: Mutt/1.5.9i From: Herbert Xu Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jun 22, 2006 at 04:57:39AM -0400, Jeff Garzik wrote: > > >>Non-linear skbs smaller than ETH_ZLEN seem unlikely. > > > >When I was grepping it seems that a few drivers were using it with > >a length other than ETH_ZLEN. I've just done another grep and here > >are the potential suspects: > > > >cassini.c > >starfire.c > >yellowfin.c > > That doesn't really invalidate the point :) These drivers are still > only padding very small packets. Hmm, at least cassini pads it to 255 for gigabit... Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt