From: Coywolf Qi Hunt <qiyong@fc-cn.com>
To: Andrew Morton <akpm@osdl.org>
Cc: linux-kernel@vger.kernel.org, rusty@rustcorp.com.au
Subject: Re: [patch] cleanup: kthread workqueue rename
Date: Thu, 22 Jun 2006 19:41:26 +0800 [thread overview]
Message-ID: <20060622114126.GA6627@localhost.localdomain> (raw)
In-Reply-To: <20060622041316.b290b19d.akpm@osdl.org>
On Thu, Jun 22, 2006 at 04:13:16AM -0700, Andrew Morton wrote:
> On Thu, 22 Jun 2006 16:29:12 +0800
> Coywolf Qi Hunt <qiyong@fc-cn.com> wrote:
>
> > -static struct workqueue_struct *helper_wq;
> > +static struct workqueue_struct *kthread_wq;
>
> "helper" is better. It's there to help kthread launching and that's all it
> does. So "helper" is a more specific identification.
So "khelper_wq" should better be "helper_wq" too?
khelper_wq = create_singlethread_workqueue("khelper");
'helper_wq' becomes [kthread] as shown in ps ax; I don't think it is a 'helper'.
5 ? S< 0:00 [khelper]
6 ? S< 0:00 [kthread]
That vague name makes me easily forget what I am looking at. Please apply.
--
Coywolf Qi Hunt
prev parent reply other threads:[~2006-06-22 11:41 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-06-22 8:29 Coywolf Qi Hunt
2006-06-22 11:13 ` Andrew Morton
2006-06-22 11:41 ` Coywolf Qi Hunt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060622114126.GA6627@localhost.localdomain \
--to=qiyong@fc-cn.com \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rusty@rustcorp.com.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®