mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Andreas Mohr <andi@rhlx01.fht-esslingen.de>
To: Nathan Lynch <ntl@pobox.com>
Cc: Andrew Morton <akpm@osdl.org>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH -mm 6/6] cpu_relax(): ptrace.c coding style fix
Date: Thu, 22 Jun 2006 17:53:17 +0200	[thread overview]
Message-ID: <20060622155317.GA9746@rhlx01.fht-esslingen.de> (raw)
In-Reply-To: <20060622143223.GK16029@localdomain>

On Thu, Jun 22, 2006 at 09:32:23AM -0500, Nathan Lynch wrote:
> Andreas Mohr wrote:
> > 
> > Fix existing cpu_relax() loop to have proper kernel style.
> > 
> 
> ...
> 
> > @@ -182,9 +182,8 @@
> >  	if (!write_trylock(&tasklist_lock)) {
> >  		local_irq_enable();
> >  		task_unlock(task);
> > -		do {
> > +		while (!write_can_lock(&tasklist_lock))
> >  			cpu_relax();
> > -		} while (!write_can_lock(&tasklist_lock));
> 
> This is a change in behavior, not just style.  (And there is nothing
> wrong with the current style.)

Ick, right, this could cause the new state to be visible in the 2nd iteration
only.

Thanks! Discard this change please.

Andreas Mohr

  reply	other threads:[~2006-06-22 15:53 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-06-21 21:00 Andreas Mohr
2006-06-22 14:32 ` Nathan Lynch
2006-06-22 15:53   ` Andreas Mohr [this message]
2006-06-22 15:08 ` Pavel Machek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060622155317.GA9746@rhlx01.fht-esslingen.de \
    --to=andi@rhlx01.fht-esslingen.de \
    --cc=akpm@osdl.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=ntl@pobox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®