mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Randy.Dunlap" <rdunlap@xenotime.net>
To: mgross@linux.intel.com
Cc: arjan@infradead.org, linux-kernel@vger.kernel.org, mark.gross@intel.com
Subject: Re: [PATCH] riport LADAR driver
Date: Thu, 22 Jun 2006 16:21:16 -0700	[thread overview]
Message-ID: <20060622162116.f914f540.rdunlap@xenotime.net> (raw)
In-Reply-To: <20060622231604.GA5208@linux.intel.com>

On Thu, 22 Jun 2006 16:16:04 -0700 mark gross wrote:

> Ok, I've addressed all of Randy's and your comments in the patch at appended to
> this email.  Its includes the re-shuffling of the functions to loose the
> declarations at the top of the file.  For the items I didn't address I have
> comments below.
> 
> Thanks for both of your inputs!
> 
> 
> On Thu, Jun 22, 2006 at 08:20:01PM +0200, Arjan van de Ven wrote:
> > On Thu, 2006-06-22 at 07:41 -0700, mark gross wrote:
> > > +
> > > +#undef PDEBUG
> > > +#ifdef RIPORT_DEBUG
> > > +#  define PDEBUG(fmt, args...) printk( KERN_DEBUG "riport: " fmt, ## args)
> > > +#else	/*  */
> > > +#  define PDEBUG(fmt, args...)
> > > +#endif	/*  */
> > 
> > what's wrong with prdebug ?
> > > +   
> 
> what is prdebug?

pr_debug() in linux/kernel.h


I'll look at the updated version later.

---
~Randy

  reply	other threads:[~2006-06-22 23:18 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-06-22 14:41 mark gross
2006-06-22 17:46 ` Randy.Dunlap
2006-06-22 18:20 ` Arjan van de Ven
2006-06-22 23:16   ` mark gross
2006-06-22 23:21     ` Randy.Dunlap [this message]
2006-06-23  5:52     ` Randy.Dunlap
2006-06-23 22:46       ` mark gross
2006-06-24 11:00         ` Arjan van de Ven
2006-06-26 20:55           ` mark gross
2006-06-26 20:51             ` Arjan van de Ven
2006-06-26 21:18               ` mark gross
2006-06-24 22:33         ` Randy.Dunlap
2006-06-24 12:48 Gross, Mark
2006-06-24 23:25 Gross, Mark

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060622162116.f914f540.rdunlap@xenotime.net \
    --to=rdunlap@xenotime.net \
    --cc=arjan@infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mark.gross@intel.com \
    --cc=mgross@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®