Re: [PATCH] x86-64 build fix

["Randy.Dunlap" <rdunlap@xenotime.net>]

On Fri, 23 Jun 2006 01:28:01 +0200 (CEST) Roman Zippel wrote:

> Hi,
> 
> On Thu, 22 Jun 2006, Dave Jones wrote:
> 
> > On Thu, Jun 22, 2006 at 03:59:43PM -0700, Andrew Morton wrote:
> > 
> >  > I don't think Jeff has sent us an example .config, but I hit this a few
> >  > times too, before we fixed it.  I think this was all triggered by a Kconfig
> >  > change in the AGP tree, so you wouldn't have seen it, but -mm did.
> > 
> > Not guilty your honour.
> > See my mail..
> > Subject: Re: intelfb: enable on x86_64
> > 
> > It got busted due to INTEL_FB becoming available on x86-64, and it doing
> > select AGP which if INTEL_FB was =m turned CONFIG_AGP=y into CONFIG_AGP=m
> > for who-knows-why reason.  This busts the IOMMU code which expects the AGP
> > code to be =y or =n
> 
> The select overrides the default (it actually overrides pretty much 
> everything, that's why one should be careful with it).

Just checking:  so the "select AGP"
sets CONFIG_AGP to the same level or value (m or y) as the option
where it is being used?


---
~Randy