From: Olivier Galibert <galibert@pobox.com>
To: Dave Jones <davej@redhat.com>,
Linux Kernel <linux-kernel@vger.kernel.org>,
akpm@osdl.org
Subject: Re: stv680 boolean logic bug.
Date: Fri, 23 Jun 2006 11:59:28 +0200 [thread overview]
Message-ID: <20060623095928.GA27774@dspnet.fr.eu.org> (raw)
In-Reply-To: <20060623004033.GA14911@redhat.com>
On Thu, Jun 22, 2006 at 08:40:33PM -0400, Dave Jones wrote:
> This looks closer to what I believe the original intent was.
> (Also fixes line-len to meet CodingStyle)
>
> Signed-off-by: Dave Jones <davej@redhat.com>
>
> --- linux-2.6/drivers/media/video/stv680.c~ 2006-06-22 20:38:21.000000000 -0400
> +++ linux-2.6/drivers/media/video/stv680.c 2006-06-22 20:39:02.000000000 -0400
> @@ -974,7 +974,8 @@ static void bayer_unshuffle (struct usb_
> frame->grabstate = FRAME_DONE;
> stv680->framecount++;
> stv680->readcount++;
> - if (stv680->frame[(stv680->curframe + 1) & (STV680_NUMFRAMES - 1)].grabstate == FRAME_READY) {
> + if (stv680->frame[(stv680->curframe + 1) &&
> + (STV680_NUMFRAMES - 1)].grabstate == FRAME_READY) {
> stv680->curframe = (stv680->curframe + 1) & (STV680_NUMFRAMES - 1);
> }
That looks very wrong. You're turning a circular buffer
into... whatever.
OG.
prev parent reply other threads:[~2006-06-23 9:59 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-06-23 0:40 Dave Jones
2006-06-23 9:59 ` Olivier Galibert [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060623095928.GA27774@dspnet.fr.eu.org \
--to=galibert@pobox.com \
--cc=akpm@osdl.org \
--cc=davej@redhat.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®