From: Christoph Hellwig <hch@infradead.org>
To: Alasdair G Kergon <agk@redhat.com>, Andrew Morton <akpm@osdl.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] dm: support ioctls on mapped devices: fix with fake file
Date: Fri, 23 Jun 2006 19:45:20 +0100 [thread overview]
Message-ID: <20060623184520.GB22172@infradead.org> (raw)
In-Reply-To: <20060623183829.GZ19222@agk.surrey.redhat.com>
On Fri, Jun 23, 2006 at 07:38:29PM +0100, Alasdair G Kergon wrote:
> [This applies after all the current dm patches.]
NACK. You should use ioctl_by_bdev and fix it to fake up the file pointer
instead. That keeps faking the file pointer in a single place and solves
the problem of NULL file pointers for other cases like the s390 partitioning
code, or various odd filesystems figuring out partition tables by themselves.
For bonus points use a common helper for both blkdev_get and ioctl_by_bdev
that creates the fake struct file.
next prev parent reply other threads:[~2006-06-23 18:45 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-06-23 18:38 Alasdair G Kergon
2006-06-23 18:45 ` Christoph Hellwig [this message]
2006-06-23 19:13 ` Alasdair G Kergon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060623184520.GB22172@infradead.org \
--to=hch@infradead.org \
--cc=agk@redhat.com \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®