mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Daniel Ritz <daniel.ritz-ml@swissonline.ch>
To: Shaohua Li <shaohua.li@intel.com>, Pavel Machek <pavel@ucw.cz>,
	"Rafael J. Wysocki" <rjw@sisk.pl>
Cc: "linux-kernel" <linux-kernel@vger.kernel.org>,
	Andrew Morton <akpm@osdl.org>, Linus Torvalds <torvalds@osdl.org>
Subject: [PATCH] swsuspend breakage in 2.6.17-git
Date: Sun, 25 Jun 2006 16:05:09 +0200	[thread overview]
Message-ID: <200606251605.10956.daniel.ritz-ml@swissonline.ch> (raw)

hello

commit b6370d96e09944c6e3ae8d5743ca8a8ab1f79f6c:
	[PATCH] swsusp: i386 mark special saveable/unsaveable pages
breaks swsusp for me with a page fault in kernel/power/snapshot.c:save_arch_mem()

the following patch makes suspend-resume working again, but some
problems still remain: fan goes on and stays on after resume (same as
in bug #5000). i guess this is a due to a change in ACPI which i still
have to track down along with the problem that acpi is not powering-off
my other laptop anymore...

comments?

rgds
-daniel


[PATCH] fix swsuspend breakage in 2.6.17-git

trying to save ACPI NVS pages leads to a pagefault on a toshiba
tecra 8000 notebook. back out saving those.

Signed-off-by: Daniel Ritz <daniel.ritz@gmx.ch>

diff --git a/arch/i386/kernel/setup.c b/arch/i386/kernel/setup.c
index e602397..c0bdf47 100644
--- a/arch/i386/kernel/setup.c
+++ b/arch/i386/kernel/setup.c
@@ -1490,7 +1490,7 @@ static void __init e820_save_acpi_pages(
 		end = ei->addr + ei->size;
 		if (start >= end)
 			continue;
-		if (ei->type != E820_ACPI && ei->type != E820_NVS)
+		if (ei->type != E820_ACPI)
 			continue;
 		/*
 		 * If the region is below max_low_pfn, it will be

             reply	other threads:[~2006-06-25 14:04 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-06-25 14:05 Daniel Ritz [this message]
2006-06-25 16:46 ` Linus Torvalds
2006-06-26  1:26   ` Shaohua Li
2006-06-26  1:49     ` Linus Torvalds

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200606251605.10956.daniel.ritz-ml@swissonline.ch \
    --to=daniel.ritz-ml@swissonline.ch \
    --cc=akpm@osdl.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pavel@ucw.cz \
    --cc=rjw@sisk.pl \
    --cc=shaohua.li@intel.com \
    --cc=torvalds@osdl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®