From: Andrew Morton <akpm@osdl.org>
To: Dave Hansen <haveblue@us.ibm.com>
Cc: vagabon.xyz@gmail.com, mel@skynet.ie, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Clean up the bootmem allocator
Date: Mon, 26 Jun 2006 11:10:22 -0700 [thread overview]
Message-ID: <20060626111022.0b31fa6e.akpm@osdl.org> (raw)
In-Reply-To: <1151344691.10877.44.camel@localhost.localdomain>
On Mon, 26 Jun 2006 10:58:11 -0700
Dave Hansen <haveblue@us.ibm.com> wrote:
> > It also removes __init tags in the header file and hopefully make it
> > easier to read.
>
> I think I kinda like when these are present in headers. I usually
> stumble across the header declarations before I do the ones in the .c
> files, and it is always nice to see the header visually _matching_
> the .c file, and how the variable is intended to be used
__init in headers is pretty useless because the compiler doesn't check it,
and they get out of sync relatively frequently. So it you see an __init
in a header file, it's quite unreliable and you need to check the
definition anyway.
next prev parent reply other threads:[~2006-06-26 18:10 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-06-26 13:11 Franck Bui-Huu
2006-06-26 17:58 ` Dave Hansen
2006-06-26 18:10 ` Andrew Morton [this message]
2006-06-27 8:23 ` Franck Bui-Huu
2006-06-27 12:53 ` [PATCH 0/7] " Franck Bui-Huu
2006-06-27 12:53 ` [PATCH 1/7] bootmem: remove useless __init in header file Franck Bui-Huu
2006-06-27 17:17 ` Dave Hansen
2006-06-27 19:18 ` Franck Bui-Huu
2006-06-27 12:53 ` [PATCH 2/7] bootmem: mark link_bootmem() as part of the __init section Franck Bui-Huu
2006-06-27 17:17 ` Dave Hansen
2006-06-27 19:18 ` Franck Bui-Huu
2006-06-27 12:54 ` [PATCH 3/7] bootmem: remove useless parentheses in bootmem header file Franck Bui-Huu
2006-06-27 12:54 ` [PATCH 4/7] bootmem: limit to 80 columns width Franck Bui-Huu
2006-06-27 12:54 ` [PATCH 5/7] bootmem: remove useless headers inclusions Franck Bui-Huu
2006-06-27 12:54 ` [PATCH 6/7] bootmem: use pfn/page conversion macros Franck Bui-Huu
2006-06-27 19:26 ` Dave Hansen
2006-06-29 7:53 ` Franck Bui-Huu
2006-06-27 12:54 ` [PATCH 7/7] bootmem: miscellaneous coding style fixes Franck Bui-Huu
2006-06-27 17:26 ` Dave Hansen
2006-06-27 19:22 ` Franck Bui-Huu
2006-06-27 22:35 ` Randy.Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060626111022.0b31fa6e.akpm@osdl.org \
--to=akpm@osdl.org \
--cc=haveblue@us.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mel@skynet.ie \
--cc=vagabon.xyz@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®