mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Serge E. Hallyn" <serue@us.ibm.com>
To: Dave Jones <davej@redhat.com>,
	"Serge E. Hallyn" <serue@us.ibm.com>,
	lkml <linux-kernel@vger.kernel.org>,
	Martin Schwidefsky <schwidefsky@de.ibm.com>,
	linux-390@vm.marist.edu
Subject: Re: [PATCH] s390: fix duplicate export of overflow{ug}id
Date: Mon, 26 Jun 2006 14:48:12 -0500	[thread overview]
Message-ID: <20060626194812.GD32035@sergelap.austin.ibm.com> (raw)
In-Reply-To: <20060626193704.GF18599@redhat.com>

Quoting Dave Jones (davej@redhat.com):
> On Mon, Jun 26, 2006 at 02:31:41PM -0500, Serge E. Hallyn wrote:
>  > overflowuid and overflowgid were exported twice.  Remove the export
>  > from s390_ksyms.c
> 
> There's a gotcha with this.  in kernel/sys.c, we only export those
> symbols if CONFIG_UID16 is set.  iirc, there was some part of
> arch/s390 that expected to use those symbols even if it wasn't set.
> 
> Does everything still link with that option both set and unset ?

It does on my partition; near as I can tell the only use of overflowuid
is in compat_linux.c, which is always compiled in.

Nevertheless a #ifndef CONFIG_UID16 is probably more appropriate?

thanks,
-serge

  reply	other threads:[~2006-06-26 19:49 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-06-26 19:31 Serge E. Hallyn
2006-06-26 19:37 ` Dave Jones
2006-06-26 19:48   ` Serge E. Hallyn [this message]
2006-06-26 20:49     ` Heiko Carstens
2006-06-26 19:46 ` Serge E. Hallyn

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060626194812.GD32035@sergelap.austin.ibm.com \
    --to=serue@us.ibm.com \
    --cc=davej@redhat.com \
    --cc=linux-390@vm.marist.edu \
    --cc=linux-kernel@vger.kernel.org \
    --cc=schwidefsky@de.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®