mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Björn Steinbrink" <B.Steinbrink@gmx.de>
To: Jean Delvare <khali@linux-fr.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
	Arjan van de Ven <arjan@linux.intel.com>
Subject: Re: [PATCH] Fix warning in do_IRQ (i386)
Date: Mon, 26 Jun 2006 23:55:27 +0200	[thread overview]
Message-ID: <20060626215527.GA6109@atjola.homenet> (raw)
In-Reply-To: <20060626230857.e92bc170.khali@linux-fr.org>

On 2006.06.26 23:08:57 +0200, Jean Delvare wrote:
> arch/i386/kernel/irq.c: In function `do_IRQ':
> arch/i386/kernel/irq.c:104: warning: suggest parentheses around arithmetic in operand of |
> 
> Signed-off-by: Jean Delvare <khali@linux-fr.org>
> Cc: Björn Steinbrink <B.Steinbrink@gmx.de>
> Cc: Arjan van de Ven <arjan@linux.intel.com>
> ---
>  arch/i386/kernel/irq.c |    4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> --- linux-2.6.17-git.orig/arch/i386/kernel/irq.c	2006-06-26 21:55:03.000000000 +0200
> +++ linux-2.6.17-git/arch/i386/kernel/irq.c	2006-06-26 22:54:49.000000000 +0200
> @@ -100,8 +100,8 @@
>  		 * softirq checks work in the hardirq context.
>  		 */
>  		irqctx->tinfo.preempt_count =
> -			irqctx->tinfo.preempt_count & ~SOFTIRQ_MASK |
> -			curctx->tinfo.preempt_count & SOFTIRQ_MASK;
> +			(irqctx->tinfo.preempt_count & ~SOFTIRQ_MASK) |
> +			(curctx->tinfo.preempt_count & SOFTIRQ_MASK);
>  
>  		asm volatile(
>  			"       xchgl   %%ebx,%%esp      \n"

Hi,

thanks for catching that one, I even fixed that on the box where the
patch was tested but then obviously sent the old patch.


Acked-by: Björn Steinbrink <B.Steinbrink@gmx.de>

      reply	other threads:[~2006-06-26 21:55 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-06-26 21:08 Jean Delvare
2006-06-26 21:55 ` Björn Steinbrink [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060626215527.GA6109@atjola.homenet \
    --to=b.steinbrink@gmx.de \
    --cc=arjan@linux.intel.com \
    --cc=khali@linux-fr.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®