mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Nigel Cunningham <nigel@suspend2.net>
To: linux-kernel@vger.kernel.org
Subject: [Suspend2][ 08/32] [Suspend2] Finish and cleanup all outstanding I/O.
Date: Tue, 27 Jun 2006 08:37:34 +1000	[thread overview]
Message-ID: <20060626223733.4376.61756.stgit@nigel.suspend2.net> (raw)
In-Reply-To: <20060626223706.4376.96042.stgit@nigel.suspend2.net>

Wait for all outstanding I/O to complete, then clean it all up and free the
io_info structs.

Signed-off-by: Nigel Cunningham <nigel@suspend2.net>

 kernel/power/suspend_block_io.c |   42 +++++++++++++++++++++++++++++++++++++++
 1 files changed, 42 insertions(+), 0 deletions(-)

diff --git a/kernel/power/suspend_block_io.c b/kernel/power/suspend_block_io.c
index 6f8b29e..5b93ad2 100644
--- a/kernel/power/suspend_block_io.c
+++ b/kernel/power/suspend_block_io.c
@@ -333,3 +333,45 @@ static void do_bio_wait(int caller)
 	suspend_cleanup_some_completed_io();
 }
 
+/*
+ * suspend_finish_all_io
+ *
+ * Description:	Finishes all IO and frees all IO info struct pages.
+ */
+static void suspend_finish_all_io(void)
+{
+	struct io_info *this, *next = NULL;
+	unsigned long flags;
+
+	/* Wait for all I/O to complete. */
+	while (atomic_read(&outstanding_io))
+		do_bio_wait(2);
+
+	spin_lock_irqsave(&ioinfo_free_lock, flags);
+	
+	/* 
+	 * Two stages, to avoid using freed pages.
+	 *
+	 * First free all io_info structs on a page except the first.
+	 */
+	list_for_each_entry_safe(this, next, &ioinfo_free, list) {
+		if (((unsigned long) this) & ~PAGE_MASK)
+			list_del(&this->list);
+	}
+
+	/* 
+	 * Now we have only one reference to each page, and can safely
+	 * free pages, knowing we're not going to be trying to access the
+	 * same page after freeing it.
+	 */
+	list_for_each_entry_safe(this, next, &ioinfo_free, list) {
+		list_del(&this->list);
+		free_page((unsigned long) this);
+		infopages--;
+		suspend_message(SUSPEND_MEMORY, SUSPEND_VERBOSE, 0,
+				"[FreedIOPage %lx]", this);
+	}
+	
+	spin_unlock_irqrestore(&ioinfo_free_lock, flags);
+}
+

--
Nigel Cunningham		nigel at suspend2 dot net

  parent reply	other threads:[~2006-06-26 23:16 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-06-26 22:37 [Suspend2][ 00/32] Block i/o patches Nigel Cunningham
2006-06-26 22:37 ` [Suspend2][ 01/32] [Suspend2] Block I/O Header File Nigel Cunningham
2006-06-26 22:37 ` [Suspend2][ 02/32] [Suspend2] Block io c file header Nigel Cunningham
2006-06-26 22:37 ` [Suspend2][ 03/32] [Suspend2] Reset block io stats Nigel Cunningham
2006-06-26 22:37 ` [Suspend2][ 04/32] [Suspend2] Check the " Nigel Cunningham
2006-06-26 22:37 ` [Suspend2][ 05/32] [Suspend2] Cleanup one page Nigel Cunningham
2006-06-26 22:37 ` [Suspend2][ 06/32] [Suspend2] Cleanup some completed I/O Nigel Cunningham
2006-06-26 22:37 ` [Suspend2][ 07/32] [Suspend2] Wait for bio completion Nigel Cunningham
2006-06-26 22:37 ` Nigel Cunningham [this message]
2006-06-26 22:37 ` [Suspend2][ 09/32] [Suspend2] Wait on a particular page Nigel Cunningham
2006-06-26 22:37 ` [Suspend2][ 10/32] [Suspend2] Wait on readahead Nigel Cunningham
2006-06-26 22:37 ` [Suspend2][ 11/32] [Suspend2] Test whether readahead is ready Nigel Cunningham
2006-06-26 22:37 ` [Suspend2][ 12/32] [Suspend2] Prepare & cleanup readahead pages Nigel Cunningham
2006-06-26 22:37 ` [Suspend2][ 13/32] [Suspend2] Suspend bio completion Nigel Cunningham
2006-06-26 22:37 ` [Suspend2][ 14/32] [Suspend2] Submit io on a page Nigel Cunningham
2006-06-26 22:38 ` [Suspend2][ 15/32] [Suspend2] Submit batched i/o Nigel Cunningham
2006-06-26 22:38 ` [Suspend2][ 16/32] [Suspend2] Add page io to a batch Nigel Cunningham
2006-06-26 22:38 ` [Suspend2][ 17/32] [Suspend2] Get an io_info struct Nigel Cunningham
2006-06-26 22:38 ` [Suspend2][ 18/32] [Suspend2] Prepare to do i/o on a page Nigel Cunningham
2006-06-26 22:38 ` [Suspend2][ 19/32] [Suspend2] Do " Nigel Cunningham
2006-06-26 22:38 ` [Suspend2][ 20/32] [Suspend2] Return memory needed for block io Nigel Cunningham
2006-06-26 22:38 ` [Suspend2][ 21/32] [Suspend2] Set device info Nigel Cunningham
2006-06-26 22:38 ` [Suspend2][ 22/32] [Suspend2] Move forward extra blocks in a page Nigel Cunningham
2006-06-26 22:38 ` [Suspend2][ 23/32] [Suspend2] Advance one page in the extent state Nigel Cunningham
2006-06-26 22:38 ` [Suspend2][ 24/32] [Suspend2] Set extra page forward flag Nigel Cunningham
2006-06-26 22:38 ` [Suspend2][ 25/32] [Suspend2] Do io on a page in the image proper Nigel Cunningham
2006-06-26 22:38 ` [Suspend2][ 26/32] [Suspend2] Read a page of the image Nigel Cunningham
2006-06-26 22:38 ` [Suspend2][ 27/32] [Suspend2] Init and cleanup routines for pageset i/o Nigel Cunningham
2006-06-26 22:38 ` [Suspend2][ 28/32] [Suspend2] Write a page in the image proper Nigel Cunningham
2006-06-26 22:38 ` [Suspend2][ 29/32] [Suspend2] Read or write a chunk of the header Nigel Cunningham
2006-06-26 22:38 ` [Suspend2][ 30/32] [Suspend2] Finish writing an image header Nigel Cunningham
2006-06-26 22:38 ` [Suspend2][ 31/32] [Suspend2] Suspend block io ops Nigel Cunningham
2006-06-26 22:39 ` [Suspend2][ 32/32] [Suspend2] Module ops for the block i/o functions Nigel Cunningham

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060626223733.4376.61756.stgit@nigel.suspend2.net \
    --to=nigel@suspend2.net \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome