From: Nigel Cunningham <nigel@suspend2.net>
To: linux-kernel@vger.kernel.org
Subject: [Suspend2][ 08/35] [Suspend2] Reopen the resume dev_t.
Date: Tue, 27 Jun 2006 08:39:30 +1000 [thread overview]
Message-ID: <20060626223929.4685.46774.stgit@nigel.suspend2.net> (raw)
In-Reply-To: <20060626223902.4685.52543.stgit@nigel.suspend2.net>
Having processed the resume2= setting once to get the dev_t it refers to,
we can just use the dev_t again afterwards. This routine reopens the bdev
at some later stage, getting afresh the inode and device info - something
might have been modified by the user since our last use, and it would be
wrong to keep the device open all the time anyway.
Signed-off-by: Nigel Cunningham <nigel@suspend2.net>
kernel/power/suspend_file.c | 19 +++++++++++++++++++
1 files changed, 19 insertions(+), 0 deletions(-)
diff --git a/kernel/power/suspend_file.c b/kernel/power/suspend_file.c
index e2ad8dc..7e06a06 100644
--- a/kernel/power/suspend_file.c
+++ b/kernel/power/suspend_file.c
@@ -259,3 +259,22 @@ static void filewriter_cleanup(int finis
}
}
+/*
+ * reopen_resume_devt
+ *
+ * Having opened resume2= once, we remember the major and
+ * minor nodes and use them to reopen the bdev for checking
+ * whether an image exists (possibly when starting a resume).
+ */
+static void reopen_resume_devt(void)
+{
+ filewriter_target_bdev = open_by_devnum(resume_dev_t, FMODE_READ);
+ if (IS_ERR(filewriter_target_bdev)) {
+ printk("Got a dev_num (%lx) but failed to open it.\n",
+ (unsigned long) resume_dev_t);
+ return;
+ }
+ target_inode = filewriter_target_bdev->bd_inode;
+ set_devinfo(filewriter_target_bdev, target_inode->i_blkbits);
+}
+
--
Nigel Cunningham nigel at suspend2 dot net
next prev parent reply other threads:[~2006-06-26 23:05 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-06-26 22:39 [Suspend2][ 00/35] Filewriter Nigel Cunningham
2006-06-26 22:39 ` [Suspend2][ 01/35] [Suspend2] Header file for suspend_file.c Nigel Cunningham
2006-06-26 22:39 ` [Suspend2][ 02/35] [Suspend2] Filewriter set_devinfo patch Nigel Cunningham
2006-06-26 22:39 ` [Suspend2][ 03/35] [Suspend2] Get filewriter storage available Nigel Cunningham
2006-06-26 22:39 ` [Suspend2][ 04/35] [Suspend2] Does a filewriter page have contiguous blocks? Nigel Cunningham
2006-06-26 22:39 ` [Suspend2][ 05/35] [Suspend2] Filewriter storage available less ignored pages Nigel Cunningham
2006-06-26 22:39 ` [Suspend2][ 06/35] [Suspend2] Filewriter populate block list Nigel Cunningham
2006-06-26 22:39 ` [Suspend2][ 07/35] [Suspend2] Filewriter cleanup Nigel Cunningham
2006-06-26 22:39 ` Nigel Cunningham [this message]
2006-06-26 22:39 ` [Suspend2][ 09/35] [Suspend2] Get filewriter target info Nigel Cunningham
2006-06-26 22:39 ` [Suspend2][ 10/35] [Suspend2] Parse filewriter signature Nigel Cunningham
2006-06-26 22:39 ` [Suspend2][ 11/35] [Suspend2] Set the filewriter signature to say we have an image Nigel Cunningham
2006-06-26 22:39 ` [Suspend2][ 12/35] [Suspend2] Get filewriter storage allocated Nigel Cunningham
2006-06-26 22:39 ` [Suspend2][ 13/35] [Suspend2] Release allocated filewriter storage Nigel Cunningham
2006-06-26 22:39 ` [Suspend2][ 14/35] [Suspend2] Allocate filewriter header storage Nigel Cunningham
2006-06-26 22:39 ` [Suspend2][ 15/35] [Suspend2] Allocate filewriter storage Nigel Cunningham
2006-06-26 22:39 ` [Suspend2][ 16/35] [Suspend2] Filewriter header writing init/cleanup Nigel Cunningham
2006-06-26 22:40 ` [Suspend2][ 17/35] [Suspend2] Filewriter initrd image support Nigel Cunningham
2006-06-26 22:40 ` [Suspend2][ 18/35] [Suspend2] Header reading initialisation specific to files Nigel Cunningham
2006-06-26 22:40 ` [Suspend2][ 19/35] [Suspend2] Filewriter header reading initialisation Nigel Cunningham
2006-06-26 22:40 ` [Suspend2][ 20/35] [Suspend2] Filewriter image header read cleanup Nigel Cunningham
2006-06-26 22:40 ` [Suspend2][ 21/35] [Suspend2] Make modifications to the filewriter signature Nigel Cunningham
2006-06-26 22:40 ` [Suspend2][ 22/35] [Suspend2] Filewriter debug info routine Nigel Cunningham
2006-06-26 22:40 ` [Suspend2][ 23/35] [Suspend2] Filewriter storage needed Nigel Cunningham
2006-06-26 22:40 ` [Suspend2][ 24/35] [Suspend2] Invalidate filewriter image Nigel Cunningham
2006-06-26 22:40 ` [Suspend2][ 25/35] [Suspend2] Does a filewriter image exist? Nigel Cunningham
2006-06-26 22:40 ` [Suspend2][ 26/35] [Suspend2] Filewriter mark that attempted to resume Nigel Cunningham
2006-06-26 22:40 ` [Suspend2][ 27/35] [Suspend2] Set filewriter resume2, having been given a filename Nigel Cunningham
2006-06-26 22:40 ` [Suspend2][ 28/35] [Suspend2] Test filewriter target value helper Nigel Cunningham
2006-06-26 22:40 ` [Suspend2][ 29/35] [Suspend2] Test filewriter target Nigel Cunningham
2006-06-26 22:40 ` [Suspend2][ 30/35] [Suspend2] Filewriter parse resume2 parameter Nigel Cunningham
2006-06-26 22:40 ` [Suspend2][ 31/35] [Suspend2] Serialise filewriter config in image header Nigel Cunningham
2006-06-26 22:40 ` [Suspend2][ 32/35] [Suspend2] Filewriter initialise Nigel Cunningham
2006-06-26 22:40 ` [Suspend2][ 33/35] [Suspend2] Filewriter proc data Nigel Cunningham
2006-06-26 22:40 ` [Suspend2][ 34/35] [Suspend2] Filewriter ops Nigel Cunningham
2006-06-26 22:41 ` [Suspend2][ 35/35] [Suspend2] Filewriter load/unload routines Nigel Cunningham
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060626223929.4685.46774.stgit@nigel.suspend2.net \
--to=nigel@suspend2.net \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome