From: Chuck Ebbert <76306.1226@compuserve.com>
To: Shaohua Li <shaohua.li@intel.com>
Cc: linux-kernel <linux-kernel@vger.kernel.org>,
Greg KH <greg@kroah.com>, Andrew Morton <akpm@osdl.org>,
Arjan van de Ven <arjan@linux.intel.com>,
Rajesh Shah <rajesh.shah@intel.com>,
Tigran Aivazian <tigran@veritas.com>
Subject: Re: [PATCH]microcode update driver rewrite - takes 2
Date: Tue, 27 Jun 2006 04:14:13 -0400 [thread overview]
Message-ID: <200606270418_MC3-1-C38C-B2BF@compuserve.com> (raw)
In-Reply-To: <1151376693.21189.52.camel@sli10-desk.sh.intel.com>
On Tue, 27 Jun 2006 10:51:33 +0800, Shaohua Li wrote:
> This is the rewrite of microcode update driver. Changes:
> + printk(KERN_ERR "microcode: error! Bad data in microcode "
> + "data file\n");
I counted five of these "generic" error messages. I know the original
driver had this problem too because I hit it and couldn't tell where
the message came from.
Could you change these messages so they're unique and they describe the
actual problem better? E.g. "data too large for user buffer" etc.?
--
Chuck
"You can't read a newspaper if you can't read." --George W. Bush
next reply other threads:[~2006-06-27 8:19 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-06-27 8:14 Chuck Ebbert [this message]
-- strict thread matches above, loose matches on Subject: below --
2006-06-27 2:51 Shaohua Li
2006-06-27 6:02 ` Greg KH
2006-06-27 8:15 ` Shaohua Li
2006-06-29 8:18 ` Shaohua Li
2006-06-29 9:03 ` Jan Beulich
2006-06-29 9:15 ` Shaohua Li
2006-06-29 9:40 ` Jan Beulich
2006-06-27 8:15 ` Shaohua Li
2006-06-27 8:15 ` Shaohua Li
2006-06-27 17:30 ` Randy.Dunlap
2006-06-28 12:16 ` Tigran Aivazian
2007-02-14 10:41 ` Alex Riesen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200606270418_MC3-1-C38C-B2BF@compuserve.com \
--to=76306.1226@compuserve.com \
--cc=akpm@osdl.org \
--cc=arjan@linux.intel.com \
--cc=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rajesh.shah@intel.com \
--cc=shaohua.li@intel.com \
--cc=tigran@veritas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®