mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Nigel Cunningham <nigel@suspend2.net>
To: linux-kernel@vger.kernel.org
Subject: [Suspend2][ 09/10] [Suspend2] Atomic copy highlevel routine.
Date: Tue, 27 Jun 2006 14:39:17 +1000	[thread overview]
Message-ID: <20060627043915.14546.4671.stgit@nigel.suspend2.net> (raw)
In-Reply-To: <20060627043846.14546.75810.stgit@nigel.suspend2.net>

This routine essentially duplicates the swsusp_suspend routine, which does
high level steps of the atomic copy. Rather than modifying that routine to
include a number of if (suspend2) else clauses, it seemed better to put a
suspend2ised copy here.

Signed-off-by: Nigel Cunningham <nigel@suspend2.net>

 kernel/power/atomic_copy.c |   31 +++++++++++++++++++++++++++++++
 1 files changed, 31 insertions(+), 0 deletions(-)

diff --git a/kernel/power/atomic_copy.c b/kernel/power/atomic_copy.c
index 75e3beb..bb5d74f 100644
--- a/kernel/power/atomic_copy.c
+++ b/kernel/power/atomic_copy.c
@@ -349,3 +349,34 @@ void suspend_copy_pageset1(void)
 	}
 }
 
+int suspend2_suspend(void)
+{
+	int error;
+
+	if ((error = arch_prepare_suspend()))
+		return error;
+	local_irq_disable();
+	/* At this point, device_suspend() has been called, but *not*
+	 * device_power_down(). We *must* device_power_down() now.
+	 * Otherwise, drivers for some devices (e.g. interrupt controllers)
+	 * become desynchronized with the actual state of the hardware
+	 * at resume time, and evil weirdness ensues.
+	 */
+	if ((error = device_power_down(PMSG_FREEZE))) {
+		printk(KERN_ERR "Some devices failed to power down, aborting suspend\n");
+		goto enable_irqs;
+	}
+
+	save_processor_state();
+	if ((error = swsusp_arch_suspend()))
+		printk(KERN_ERR "Error %d suspending\n", error);
+	/* Restore control flow appears here */
+	restore_processor_state();
+	if (!suspend2_in_suspend)
+		copyback_high();
+	device_power_up();
+enable_irqs:
+	local_irq_enable();
+	return error;
+}
+

--
Nigel Cunningham		nigel at suspend2 dot net

  parent reply	other threads:[~2006-06-27  4:39 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-06-27  4:38 [Suspend2][ 00/10] Suspend2 Atomic Copy Patches Nigel Cunningham
2006-06-27  4:38 ` [Suspend2][ 01/10] [Suspend2] Atomic copy file header Nigel Cunningham
2006-06-27  4:38 ` [Suspend2][ 02/10] [Suspend2] Initialise nosave zone table Nigel Cunningham
2006-06-27  4:38 ` [Suspend2][ 03/10] [Suspend2] Atomic copy get_next_bit_on routine Nigel Cunningham
2006-06-27  4:39 ` [Suspend2][ 04/10] [Suspend2] Prepare pbe list for atomic restore Nigel Cunningham
2006-06-27  4:39 ` [Suspend2][ 05/10] [Suspend2] Highmem copyback routine Nigel Cunningham
2006-06-27  4:39 ` [Suspend2][ 06/10] [Suspend2] Post-atomic restore routine Nigel Cunningham
2006-06-27  4:39 ` [Suspend2][ 07/10] [Suspend2] Post suspend context-save routine Nigel Cunningham
2006-06-27  4:39 ` [Suspend2][ 08/10] [Suspend2] Atomic copy routine Nigel Cunningham
2006-06-27  4:39 ` Nigel Cunningham [this message]
2006-06-27  4:39 ` [Suspend2][ 10/10] [Suspend2] Atomic restore highlevel routine Nigel Cunningham

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060627043915.14546.4671.stgit@nigel.suspend2.net \
    --to=nigel@suspend2.net \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®