From: "Randy.Dunlap" <rdunlap@xenotime.net>
To: "Jon Smirl" <jonsmirl@gmail.com>
Cc: linux-kernel@vger.kernel.org, alan@lxorguk.ukuu.org.uk,
adaplas@gmail.com
Subject: Re: [PATCH] move MAX_NR_CONSOLES from tty.h to vt.h
Date: Tue, 27 Jun 2006 12:50:24 -0700 [thread overview]
Message-ID: <20060627125024.45ad9f91.rdunlap@xenotime.net> (raw)
In-Reply-To: <9e4733910606271203w4ceb6216g92f5fefee654aaf3@mail.gmail.com>
On Tue, 27 Jun 2006 15:03:50 -0400 Jon Smirl wrote:
> MAX_NR_CONSOLES is more of a function of the VT layer than the TTY
> one. Moving this to vt.h allows all of the framebuffer drivers to
> remove their dependency on tty.h. Note that console drivers in
> video/console still depend on tty.h but fbdev drivers should not
> depend on the tty layer.
>
> Signed-off-by: Jon Smirl <jonsmir@gmail.com>
BTW, what are these other 2 added #includes about?
> diff --git a/drivers/video/vga16fb.c b/drivers/video/vga16fb.c
> index 4fd2a27..608fba0 100644
> --- a/drivers/video/vga16fb.c
> +++ b/drivers/video/vga16fb.c
> @@ -15,13 +15,13 @@ #include <linux/kernel.h>
> #include <linux/errno.h>
> #include <linux/string.h>
> #include <linux/mm.h>
> -#include <linux/tty.h>
> #include <linux/slab.h>
> #include <linux/delay.h>
> #include <linux/fb.h>
> #include <linux/ioport.h>
> #include <linux/init.h>
> #include <linux/platform_device.h>
> +#include <linux/screen_info.h>
>
> #include <asm/io.h>
> #include <video/vga.h>
> diff --git a/include/linux/console_struct.h b/include/linux/console_struct.h
> index f8e5587..25423f7 100644
> --- a/include/linux/console_struct.h
> +++ b/include/linux/console_struct.h
> @@ -9,6 +9,7 @@
> * to achieve effects such as fast scrolling by changing the origin.
> */
>
> +#include <linux/wait.h>
> #include <linux/vt.h>
>
> struct vt_struct;
---
~Randy
next prev parent reply other threads:[~2006-06-27 19:47 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-06-27 19:03 Jon Smirl
2006-06-27 19:50 ` Randy.Dunlap [this message]
2006-06-28 23:15 ` Antonino A. Daplas
2006-06-28 23:39 ` Jon Smirl
2006-06-28 23:45 ` Antonino A. Daplas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060627125024.45ad9f91.rdunlap@xenotime.net \
--to=rdunlap@xenotime.net \
--cc=adaplas@gmail.com \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=jonsmirl@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®