From: Daniel Ritz <daniel.ritz-ml@swissonline.ch>
To: Sam Ravnborg <sam@ravnborg.org>
Cc: Linus Torvalds <torvalds@osdl.org>,
Michal Piotrowski <michal.k.k.piotrowski@gmail.com>,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: oom-killer problem
Date: Tue, 27 Jun 2006 14:21:44 +0200 [thread overview]
Message-ID: <200606271421.45497.daniel.ritz-ml@swissonline.ch> (raw)
In-Reply-To: <20060627053950.GA26435@mars.ravnborg.org>
On Tuesday 27 June 2006 07.39, Sam Ravnborg wrote:
> On Mon, Jun 26, 2006 at 04:05:40PM -0700, Linus Torvalds wrote:
> > On Tue, 27 Jun 2006, Daniel Ritz wrote:
> > >
> > > reverting the attached patch fixes the problem...
> >
> > Michal, can you also confirm that just doing a simple revert of that one
> > commit makes things work for you?
> >
> > Sam, if I don't hear otherwise from you, and Michael confirms, I'll just
> > revert it for now, and you can figure out how to fix it without breakage?
> I will try to find time during the weekend to track down the cause of
> this.
> But by reverting said patch you also have to revert:
> 566f81ca598f80de03e80a9a743e94b65b4e017e
>
> This is the patch where make -rR is enabled and that one initally caused
> problems for ia64.
>
> Sam
>
this little something on top (instead of reverting the patch) also fixes the
problem for me. because the module name depends on the name of module.mod.o
it's necessary to call basename twice on that, otherwise the name ends up
being module.mod
maybe we could also define basetarget in Kbuild.include as:
basetarget = $(basename $(basename $(notdir $@)))
but that might be too much...dunno
diff --git a/scripts/Makefile.build b/scripts/Makefile.build
index 3cb445c..e66f6dc 100644
--- a/scripts/Makefile.build
+++ b/scripts/Makefile.build
@@ -117,7 +117,7 @@ quiet_modtag := $(empty) $(empty)
$(obj-m) : quiet_modtag := [M]
# Default for not multi-part modules
-modname = $(basetarget)
+modname = $(basename $(basetarget))
$(multi-objs-m) : modname = $(modname-multi)
$(multi-objs-m:.o=.i) : modname = $(modname-multi)
diff --git a/scripts/Makefile.modpost b/scripts/Makefile.modpost
index e83613e..17f3d31 100644
--- a/scripts/Makefile.modpost
+++ b/scripts/Makefile.modpost
@@ -72,7 +72,7 @@ # Declare generated files as targets for
# Step 5), compile all *.mod.c files
# modname is set to make c_flags define KBUILD_MODNAME
-modname = $(basetarget)
+modname = $(basename $(basetarget))
quiet_cmd_cc_o_c = CC $@
cmd_cc_o_c = $(CC) $(c_flags) $(CFLAGS_MODULE) \
next prev parent reply other threads:[~2006-06-27 12:20 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-06-26 22:28 Daniel Ritz
2006-06-26 23:05 ` Linus Torvalds
2006-06-26 23:42 ` Michal Piotrowski
2006-06-27 5:39 ` Sam Ravnborg
2006-06-27 12:21 ` Daniel Ritz [this message]
2006-06-28 1:15 ` Linus Torvalds
2006-06-28 1:42 ` Keith Owens
2006-06-28 13:37 ` Daniel Ritz
2006-07-02 18:12 ` Kyle Moffett
-- strict thread matches above, loose matches on Subject: below --
2006-06-26 20:06 Michal Piotrowski
2006-06-26 20:36 ` Linus Torvalds
2006-06-26 22:24 ` Michal Piotrowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200606271421.45497.daniel.ritz-ml@swissonline.ch \
--to=daniel.ritz-ml@swissonline.ch \
--cc=linux-kernel@vger.kernel.org \
--cc=michal.k.k.piotrowski@gmail.com \
--cc=sam@ravnborg.org \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®