From: Evgeniy Polyakov <johnpol@2ka.mipt.ru>
To: Matt Helsley <matthltc@us.ibm.com>
Cc: "Chandra S. Seetharaman" <sekharan@us.ibm.com>,
LKML <linux-kernel@vger.kernel.org>,
Guillaume Thouvenin <guillaume.thouvenin@bull.net>,
Michael Kerrisk <michael.kerrisk@gmx.net>
Subject: Re: [RFC][PATCH 3/3] Process events biarch bug: New process events connector value
Date: Wed, 28 Jun 2006 09:53:26 +0400 [thread overview]
Message-ID: <20060628055326.GB12276@2ka.mipt.ru> (raw)
In-Reply-To: <1151444382.21787.1858.camel@stark>
On Tue, Jun 27, 2006 at 02:39:42PM -0700, Matt Helsley (matthltc@us.ibm.com) wrote:
> > Is there a reason why the # of listeners part is removed (basically the
> > LISTEN/IGNORE) ? and why as part of this patch ?
>
> Michael Kerrisk had some objections to LISTEN/IGNORE and I've been
> looking into making a connector function that would replace them. They
> exist primarily to improve performance by avoiding the memory allocation
> in cn_netlink_send() when there are no listeners.
Connector supports check for listeners before allocation quite long ago.
> > > + err = cn_add_callback(&cn_proc_event_id, "cn_proc", NULL);
> >
> > is this needed if you are not going to have the callback ?
>
> I believe so. Evgeniy?
Depending on how are you going to use it.
It is obviously required for receiving data from userspace, but if you
only want to send data from kernelspace you can use cn_netlink_send()
without registering callback, but in that case you must provide group
number to cn_netlink_send().
> Thanks,
> -Matt Helsley
--
Evgeniy Polyakov
next prev parent reply other threads:[~2006-06-28 5:53 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20060627112644.804066367@localhost.localdomain>
2006-06-27 11:47 ` [RFC][PATCH 1/3] Process events biarch bug: Name process event data union type and annotate for compatibility Matt Helsley
2006-06-27 11:48 ` [RFC][PATCH 2/3] Process events biarch bug: Process events timestamp bug Matt Helsley
2006-06-27 11:49 ` [RFC][PATCH 3/3] Process events biarch bug: New process events connector value Matt Helsley
2006-06-27 19:14 ` Chandra Seetharaman
2006-06-27 21:39 ` Matt Helsley
2006-06-27 23:54 ` Chandra Seetharaman
2006-06-28 1:29 ` Matt Helsley
2006-06-28 5:53 ` Evgeniy Polyakov [this message]
2006-06-30 8:46 ` Evgeniy Polyakov
2006-06-28 6:00 Albert Cahalan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060628055326.GB12276@2ka.mipt.ru \
--to=johnpol@2ka.mipt.ru \
--cc=guillaume.thouvenin@bull.net \
--cc=linux-kernel@vger.kernel.org \
--cc=matthltc@us.ibm.com \
--cc=michael.kerrisk@gmx.net \
--cc=sekharan@us.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®