mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: mingo@redhat.com
Cc: linux-kernel@vger.kernel.org
Subject: SA_TRIGGER_* vs. SA_SAMPLE_RANDOM
Date: Thu, 29 Jun 2006 14:17:03 -0700 (PDT)	[thread overview]
Message-ID: <20060629.141703.59468770.davem@davemloft.net> (raw)


Since SA_SAMPLE_RANDOM is defined as "SA_RESTART", it
could be just about any value.

On sparc, it's value is "2", so it aliases some of
the SA_TRIGGER_* defines the new genirq code adds.
And therefore we get a bunch of these on sparc64:

[   16.650540] setup_irq(2) SA_TRIGGERset. No set_type function available

(btw: missing space in the kernel log message between 'SA_TRIGGER'
      and 'set' :-)

I can't see any reason why SA_SAMPLE_RANDOM is set to
a signal mask value, or why IRQ flags are defined in
linux/signal.h :-)

Anyways, probably the best bet for now is to define
SA_SAMPLE_RANDOM explicitly to some value instead of
relying on the arbitrary platform definition of SA_RANDOM.

Ingo could you cook up and submit a patch which does this?
Thanks.

             reply	other threads:[~2006-06-29 21:17 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-06-29 21:17 David Miller [this message]
2006-06-30 14:00 ` Thomas Gleixner
2006-06-30 18:47   ` Russell King
2006-06-30 20:21     ` David Miller
2006-06-30 20:27       ` Thomas Gleixner
2006-06-30 20:31         ` David Miller
2006-06-30 22:25           ` Thomas Gleixner
2006-07-01  0:14             ` Benjamin Herrenschmidt
2006-07-01  0:10   ` Benjamin Herrenschmidt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060629.141703.59468770.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome