Re: 2.6.17-mm4

[Andrew Morton <akpm@osdl.org>]

Chris Rode <rodec@mrduck.net> wrote:
>
> Starting with -mm3 and continuing with -mm4, I'm getting:
> 
> % make modules_install
> ...
> if [ -r System.map -a -x /sbin/depmod ]; then /sbin/depmod -ae -F 
> System.map  2.6.17-mm4; fi
> WARNING: /lib/modules/2.6.17-mm4/kernel/arch/i386/kernel/msr.ko needs 
> unknown symbol register_cpu_notifier
> WARNING: /lib/modules/2.6.17-mm4/kernel/arch/i386/kernel/cpuid.ko needs 
> unknown symbol register_cpu_notifier
> 
> Defining CONFIG_HOTPLUG_CPU resolves it.  Config is attached.

Thanks.

Chandra, I assume we do this?

--- a/arch/i386/kernel/msr.c~msrc-usr-register_hotcpu_notifier
+++ a/arch/i386/kernel/msr.c
@@ -292,7 +292,7 @@ static int __init msr_init(void)
 		if (err != 0)
 			goto out_class;
 	}
-	register_cpu_notifier(&msr_class_cpu_notifier);
+	register_hotcpu_notifier(&msr_class_cpu_notifier);
 
 	err = 0;
 	goto out;
@@ -315,7 +315,7 @@ static void __exit msr_exit(void)
 		class_device_destroy(msr_class, MKDEV(MSR_MAJOR, cpu));
 	class_destroy(msr_class);
 	unregister_chrdev(MSR_MAJOR, "cpu/msr");
-	unregister_cpu_notifier(&msr_class_cpu_notifier);
+	unregister_hotcpu_notifier(&msr_class_cpu_notifier);
 }
 
 module_init(msr_init);
_