From: Chris Wedgwood <cw@f00f.org>
To: Greg KH <greg@kroah.com>, gregkh@suse.de
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] 64bit Resource: finally enable 64bit resource sizes
Date: Thu, 29 Jun 2006 13:42:06 -0700 [thread overview]
Message-ID: <20060629204206.GA3010@tuatara.stupidest.org> (raw)
In-Reply-To: <200606291801.k5TI12br003227@hera.kernel.org>
what am i missing here?
> --- a/arch/i386/Kconfig
> +++ b/arch/i386/Kconfig
> @@ -529,6 +529,7 @@ config X86_PAE
> bool
> depends on HIGHMEM64G
> default y
> + select RESOURCES_64BIT
>
> # Common NUMA Features
> config NUMA
this isn't a similar option for x86_64, so...
> diff --git a/include/linux/types.h b/include/linux/types.h
> index a021e15..3f23566 100644
> --- a/include/linux/types.h
> +++ b/include/linux/types.h
> @@ -178,9 +178,14 @@ #endif
> #ifdef __KERNEL__
> typedef unsigned __bitwise__ gfp_t;
>
> -typedef unsigned long resource_size_t;
> +#ifdef CONFIG_RESOURCES_64BIT
> +typedef u64 resource_size_t;
> +#else
> +typedef u32 resource_size_t;
> #endif
>
> +#endif /* __KERNEL__ */
> +
> struct ustat {
> __kernel_daddr_t f_tfree;
> __kernel_ino_t f_tinode;
means that on x86_64 resource_size_t will ot be 32-bit when previously
it was 64
next parent reply other threads:[~2006-06-29 20:42 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <200606291801.k5TI12br003227@hera.kernel.org>
2006-06-29 20:42 ` Chris Wedgwood [this message]
2006-06-29 20:45 ` Dave Jones
2006-06-29 20:52 ` Chris Wedgwood
2006-06-29 20:55 ` Dave Jones
2006-06-29 21:00 ` Chris Wedgwood
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060629204206.GA3010@tuatara.stupidest.org \
--to=cw@f00f.org \
--cc=greg@kroah.com \
--cc=gregkh@suse.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®